Re: [PATCH 02/19] mkfs: sanitise ftype parameter values.

Eric Sandeen
2016-03-29T16:18:02Z

On 3/29/16 11:11 AM, Jan Tulak wrote:
> On Thu, Mar 24, 2016 at 5:33 PM, Eric Sandeen <sandeen@sandeen.net <mailto:sandeen@sandeen.net>>wrote:
>
>
>
> On 3/24/16 6:15 AM, jtulak@redhat.com <mailto:jtulak@redhat.com> wrote:
> > From: Dave Chinner <dchinner@redhat.com <mailto:dchinner@redhat.com>>
> >
> > Because passing "-n ftype=2" should fail.
>
> but passing crc=1 ftype=1 shouldn't fail, should it?
> Seems like it will here.
>
>
> ​From man page:
> When CRCs are enabled via -m crc=1, the ftype functionality is always enabled. This feature can not be
> ​
> turned off for such filesystem configurations.​
>
>
> ​So I think it should not be possible to enter both crc and ftype at
> the same time - which is the current behaviour. It feels strange a
> bit to allow ftype=1 (which does nothing with crc=1), but fail on
> ftype=0​

My point is that -m crc=1 -d ftype=1 simply restates the defaults.
Why should that combination fail?

And -m crc=0 -d ftype=0 is also perfectly acceptable.

In fact, -m crc=1 -d ftype=0 is the only one of the 4 combinations
which is not ok, but AFAICT your patch fails the other 3 as well.

-Eric