Re: [PATCH 17/19] xfsprogs: disable truncating of files

Eric Sandeen
2016-04-13T16:17:53Z

On 4/13/16 10:08 AM, Jan Tulak wrote:

...

> All right​, I will keep the O_TRUNC there. However, should it
> truncate the file every time, or should we offer a way how to avoid
> the file truncating? Until now, mkfs behaved differently based on
> whether -d file was given, or not. Your explanation suggests that we
> should truncate every time, right?

There are probably valid reasons to keep size as well as to truncate;
it's not immediately clear to me how we should handle it.

Honestly, at this point, in the interest of getting the other fixes in,
I think I might rather see the truncating behavior unchanged from what
we have today; we can tackle that as a separate problem at a later date.

What do you think?

-Eric

>
> ​Cheers,
> Jan​