Re: [PATCH 15/19] mkfs: don't treat files as though they are block devices

Jan Tulak
2016-04-14T09:49:36Z

[-- Attachment #1.1: Type: text/plain, Size: 1250 bytes --]

On Fri, Apr 8, 2016 at 4:58 PM, Jan Tulak <jtulak@redhat.com> wrote:

> On Fri, Apr 8, 2016 at 2:25 AM, Eric Sandeen <sandeen@sandeen.net> wrote:
>
>
[
>> ​snip]​
>>
>> I still think this patch might need a reset though :)
>>
>> Thanks,
>> -Eric
>>
>>
> ​On few places, the original patch looked as if files had direct IO still
> enabled​ (using platform_findsize...), and I think it was causing some
> failures - fixing issues is why I did most of the changes.
>
> I will revert to the original version and see what exactly fails. But with
> being Friday late afternoon, the results will be available the next week
> (Wednesday and further, all my courses at university are stuffed in
> Mon/Tue).
>
>
​All right. So I run the tests on the set with both this and the original
version of this patch and there is no change in results. Here and there
some tests failed on one run, but on other runs they are ok and I can't get
them to fail again (namely, xfs/033, 073 and 085 did this).

It looks like whatever the issues were to start the changes, they are
already resolved. Thus, I will send the original patch in the next batch.

Cheers,
​Jan​

--
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 4148 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]