Re: [PATCH 18/19] mkfs: unit conversions are case insensitive

Jan Tulak
2016-04-07T10:50:45Z

[-- Attachment #1.1: Type: text/plain, Size: 822 bytes --]

On Wed, Apr 6, 2016 at 11:10 PM, Eric Sandeen <sandeen@sandeen.net> wrote:

> On 3/24/16 6:15 AM, jtulak@redhat.com wrote:
> > From: Jan Tulak <jtulak@redhat.com>
> >
> > Solves the question "Should I use 10g or 10G?"
>
> Might be nicer to do it like the cvtnum in libxcmd:
>
> c = tolower(*sp);
> switch (c) {
> case 'b':
> return i * blocksize;
> ...
>
​Yeah, changed.
​

>
> (hm, why do we have 3 copies of cvtnum?)
>

​Where? ​
​

​$ pwd
​/some/path/xfsprogs-dev

$ grep -r "cvtnum(size_t" . |grep -v "^Binary"
​./include/input.h:extern long long cvtnum(size_t blocksize, size_t
sectorsize, char *s);
./io/init.h:extern void init_cvtnum(size_t *blocksize, size_t *sectsize);

--
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 2779 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]