Re: [PATCH 18/19] mkfs: unit conversions are case insensitive

Eric Sandeen
2016-04-08T00:42:02Z

On 4/7/16 5:50 AM, Jan Tulak wrote:
> On Wed, Apr 6, 2016 at 11:10 PM, Eric Sandeen <sandeen@sandeen.net <mailto:sandeen@sandeen.net>>wrote:
>
> On 3/24/16 6:15 AM, jtulak@redhat.com <mailto:jtulak@redhat.com> wrote:
> > From: Jan Tulak <jtulak@redhat.com <mailto:jtulak@redhat.com>>
> >
> > Solves the question "Should I use 10g or 10G?"
>
> Might be nicer to do it like the cvtnum in libxcmd:
>
> c = tolower(*sp);
> switch (c) {
> case 'b':
> return i * blocksize;
> ...
>
> ​Yeah, changed.
> ​
>
>
>
> (hm, why do we have 3 copies of cvtnum?)
>
>
> ​Where? ​
> ​
>
> ​$ pwd
> ​/some/path/xfsprogs-dev
>
> $ grep -r "cvtnum(size_t" . |grep -v "^Binary"
> ​./include/input.h:extern long long cvtnum(size_t blocksize, size_t sectorsize, char *s);
> ./io/init.h:extern void init_cvtnum(size_t *blocksize, size_t *sectsize);

File Line
0 estimate/xfs_estimate.c 29 cvtnum(char *s)
1 libxcmd/input.c 147 cvtnum(
2 mkfs/xfs_mkfs.c 3618 cvtnum(

-Eric