Re: [PATCH 02/19] mkfs: sanitise ftype parameter values.

Jan Tulak
2016-03-29T16:12:06Z

[-- Attachment #1.1: Type: text/plain, Size: 792 bytes --]

On Thu, Mar 24, 2016 at 5:33 PM, Eric Sandeen <sandeen@sandeen.net> wrote:

>
>
> On 3/24/16 6:15 AM, jtulak@redhat.com wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Because passing "-n ftype=2" should fail.
>
> but passing crc=1 ftype=1 shouldn't fail, should it?
> Seems like it will here.
>

​From man page:
When CRCs are enabled via -m crc=1, the ftype functionality is always
enabled. This feature can not be
​
turned off for such filesystem configurations.​

​So I think it should not be possible to enter both crc and ftype at the
same time - which is the current behaviour. It feels strange a bit to allow
ftype=1 (which does nothing with crc=1), but fail on ftype=0​

​Jan​

--
Jan Tulak
jtulak@redhat.com / jan@tulak.me

[-- Attachment #1.2: Type: text/html, Size: 2352 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]