From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 82D527CA0 for ; Wed, 11 May 2016 12:52:12 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id D399FAC002 for ; Wed, 11 May 2016 10:52:08 -0700 (PDT) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0084.outbound.protection.outlook.com [65.55.169.84]) by cuda.sgi.com with ESMTP id yzqPGOdumc0IccDU (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO) for ; Wed, 11 May 2016 10:52:06 -0700 (PDT) From: Bart Van Assche Subject: 4.6-rc7 xfs circular locking dependency Message-ID: <57337140.3020905@sandisk.com> Date: Wed, 11 May 2016 10:52:00 -0700 MIME-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com Hi Dave, While retesting the SRP initiator with xfstests on top of an XFS filesystem I hit the below call trace once. I do not expect that this is related to the SRP initiator changes I made. Please let me know if you need more information. Thanks, Bart. ====================================================== [ INFO: possible circular locking dependency detected ] 4.6.0-rc7-dbg+ #1 Not tainted ------------------------------------------------------- fsstress/17356 is trying to acquire lock: (sb_internal#2){++++.+}, at: [] __sb_start_write+0xb2/0xf0 but task is already holding lock: (&s->s_sync_lock){+.+...}, at: [] sync_inodes_sb+0xbd/0x1d0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: nc_lock){+.+...}: [] lock_acquire+0x60/0x80 [] mutex_lock_nested+0x5f/0x360 [] sync_inodes_sb+0xbd/0x1d0 [] xfs_flush_inodes+0x23/0x30 [xfs] [] xfs_create+0x46f/0x5f0 [xfs] [] xfs_generic_create+0x1b9/0x290 [xfs] [] xfs_vn_mknod+0xf/0x20 [xfs] [] xfs_vn_create+0xe/0x10 [xfs] [] vfs_create+0x76/0xd0 [] path_openat+0xc1e/0x10d0 [] do_filp_open+0x79/0xd0 [] do_sys_open+0x116/0x1f0 [] SyS_creat+0x19/0x20 [] entry_SYSCALL_64_fastpath+0x18/0xa8 nal#2){++++.+}: [] __lock_acquire+0x1b0f/0x1b20 [] lock_acquire+0x60/0x80 [] percpu_down_read+0x45/0x90 [] __sb_start_write+0xb2/0xf0 [] xfs_trans_alloc+0x1f/0x40 [xfs] [] xfs_inactive_truncate+0x20/0x130 [xfs] [] xfs_inactive+0x1ae/0x1e0 [xfs] [] xfs_fs_evict_inode+0xb8/0xc0 [xfs] [] evict+0xb3/0x180 [] iput+0x14c/0x1e0 [] sync_inodes_sb+0x145/0x1d0 [] sync_inodes_one_sb+0x10/0x20 [] iterate_supers+0xaa/0x100 [] sys_sync+0x30/0x90 [] entry_SYSCALL_64_fastpath+0x18/0xa8 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_sync_lock); lock(sb_internal#2); lock(&s->s_sync_lock); lock(sb_internal#2); *** DEADLOCK *** 2 locks held by fsstress/17356: #0: (&type->s_umount_key#34){++++++}, at: [] iterate_supers+0x94/0x100 #1: (&s->s_sync_lock){+.+...}, at: [] sync_inodes_sb+0xbd/0x1d0 stack backtrace: CPU: 2 PID: 17356 Comm: fsstress Not tainted 4.6.0-rc7-dbg+ #1 Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014 0000000000000000 ffff880442b3bbe0 ffffffff812ac6b5 ffffffff8238e0c0 ffffffff8238e0c0 ffff880442b3bc20 ffffffff810a1233 ffff880442b3bc70 ffff8804153635c0 ffff880415363598 ffff880415362d80 ffff880415363570 Call Trace: [] dump_stack+0x67/0x92 [] print_circular_bug+0x1e3/0x250 [] __lock_acquire+0x1b0f/0x1b20 [] ? truncate_inode_pages_range+0x2af/0x790 [] lock_acquire+0x60/0x80 [] ? __sb_start_write+0xb2/0xf0 [] percpu_down_read+0x45/0x90 [] ? __sb_start_write+0xb2/0xf0 [] __sb_start_write+0xb2/0xf0 [] ? mark_held_locks+0x6f/0xa0 [] xfs_trans_alloc+0x1f/0x40 [xfs] [] xfs_inactive_truncate+0x20/0x130 [xfs] [] xfs_inactive+0x1ae/0x1e0 [xfs] [] xfs_fs_evict_inode+0xb8/0xc0 [xfs] [] evict+0xb3/0x180 [] iput+0x14c/0x1e0 [] sync_inodes_sb+0x145/0x1d0 [] ? SyS_tee+0x400/0x400 [] sync_inodes_one_sb+0x10/0x20 [] iterate_supers+0xaa/0x100 [] sys_sync+0x30/0x90 [] entry_SYSCALL_64_fastpath+0x18/0xa8 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs