Re: [PATCH 42/45] block, fs, drivers: remove REQ_OP compat defs and related code

Hannes Reinecke
2016-06-06T06:53:07Z

On 06/05/2016 09:32 PM, mchristi@redhat.com wrote:
> From: Mike Christie <mchristi@redhat.com>
>
> This patch drops the compat definition of req_op where it matches
> the rq_flag_bits definitions, and drops the related old and compat
> code that allowed users to set either the op or flags for the operation.
>
> We also then store the operation in the bi_rw/cmd_flags field similar
> to how we used to store the bio ioprio where it sat in the upper bits
> of the field.
>
> Signed-off-by: Mike Christie <mchristi@redhat.com>
> ---
> drivers/scsi/sd.c | 2 +-
> include/linux/bio.h | 3 ---
> include/linux/blk_types.h | 52 +++++++++++++++++----------------------------
> include/linux/blkdev.h | 14 ++++++++----
> include/linux/fs.h | 37 +++++++++++++-------------------
> include/trace/events/f2fs.h | 1 -
> 6 files changed, 46 insertions(+), 63 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)