From: Mark Tinguely <tinguely@sgi.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: in _attrlist_by_handle, copy the cursor back to userspace
Date: Tue, 2 Aug 2016 17:47:33 -0500 [thread overview]
Message-ID: <57A12305.7020506@sgi.com> (raw)
In-Reply-To: <20160802214101.GM16044@dastard>
On 08/02/16 16:41, Dave Chinner wrote:
> On Tue, Aug 02, 2016 at 08:40:35AM -0700, Darrick J. Wong wrote:
>> On Tue, Aug 02, 2016 at 05:25:17AM -0700, Christoph Hellwig wrote:
>>> On Mon, Aug 01, 2016 at 08:56:51PM -0700, Darrick J. Wong wrote:
>>>> When we're iterating inode xattrs by handle, we have to copy the
>>>> cursor back to userspace so that a subsequent invocation actually
>>>> retrieves subsequent contents.
>>> Testcase?
>> Found it while continuing development of xfs_scrub. I'll send along the
>> xfstest patch when I've finished polishing it. (It was harder than usual since
>> xfs_io doesn't /use/ the attr-by-handle interface... nothing does.)
> It was (and probably still is) used by SGI's HSM. I thought there
> was some coverage of the interface in the dmapi part of the xfstests
> suite, but perhaps it's only tested by SGI's internal hsm test
> suite...
>
> Cheers,
>
> Dave.
You may be thinking of the DMAPI specific extended attribute interface
and that is tested in xfstests. That function cannot cursor.
This change would be appropriate to xfsdump (dumping extended attributes
via jdm_attr_list()) than our HSM.
I don't see a SGI test for attr_list_by_handle() nor jdm_attr_list().
There is mention in the xfstests source file src/open_unlink.c but that
does not cursor.
--Mark Tinguely.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-02 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 3:56 [PATCH] xfs: in _attrlist_by_handle, copy the cursor back to userspace Darrick J. Wong
2016-08-02 12:25 ` Christoph Hellwig
2016-08-02 15:40 ` Darrick J. Wong
2016-08-02 21:41 ` Dave Chinner
2016-08-02 22:47 ` Mark Tinguely [this message]
2016-08-02 23:57 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A12305.7020506@sgi.com \
--to=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox