From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id DCD677CA2 for ; Tue, 13 Sep 2016 02:24:19 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id AD31B8F8035 for ; Tue, 13 Sep 2016 00:24:16 -0700 (PDT) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [58.251.152.64]) by cuda.sgi.com with ESMTP id qtJWjCvvBoIcHS73 (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Tue, 13 Sep 2016 00:24:13 -0700 (PDT) Subject: Re: [PATCH] xfs: fix signed integer overflow References: <1473403112-31072-1-git-send-email-xiexiuqi@huawei.com> <1473403321.13672.35.camel@perches.com> <57D261E0.7080005@huawei.com> <20160913065738.GF30497@dastard> From: Xie XiuQi Message-ID: <57D7A97B.4080901@huawei.com> Date: Tue, 13 Sep 2016 15:23:39 +0800 MIME-Version: 1.0 In-Reply-To: <20160913065738.GF30497@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Joe Perches , linux-kernel@vger.kernel.org, xfs@oss.sgi.com On 2016/9/13 14:57, Dave Chinner wrote: > On Fri, Sep 09, 2016 at 03:16:48PM +0800, Xie XiuQi wrote: >> On 2016/9/9 14:42, Joe Perches wrote: >>> On Fri, 2016-09-09 at 14:38 +0800, Xie XiuQi wrote: >>>> Use 1U for unsigned long, or we'll meet a overflow issue with UBSAN. >>> trivia: misleading commit message >>> >>> 1U is for unsigned int not unsigned long int >>> >> Sorry, my fault. Thank you for your comments. >> >> From 9cb8e36406a54ce0eaade31dd28f6068f03de1d2 Mon Sep 17 00:00:00 2001 >> From: Xie XiuQi >> Date: Tue, 6 Sep 2016 11:15:34 +0800 >> Subject: [PATCH v2] xfs: fix signed integer overflow > .... >> --- >> fs/xfs/xfs_buf_item.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c >> index e455f90..3a27997 100644 >> --- a/fs/xfs/xfs_buf_item.c >> +++ b/fs/xfs/xfs_buf_item.c >> @@ -865,7 +865,7 @@ xfs_buf_item_log_segment( >> */ >> if (bit) { >> end_bit = MIN(bit + bits_to_set, (uint)NBWORD); >> - mask = ((1 << (end_bit - bit)) - 1) << bit; >> + mask = ((1U << (end_bit - bit)) - 1) << bit; >> *wordp |= mask; >> wordp++; >> bits_set = end_bit - bit; > This patch is whitespace damaged and fails to apply. I've fixed it > up as this is a trivial change. However, please fix the problem > before you submit more patches. I will, thank you very mush. > > Cheers, > > Dave. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs