Re: [PATCH v7 01/19] xfs: Replace attribute parameters with struct xfs_name

Allison Collins
2020-02-24T16:25:08Z

On 2/24/20 5:08 AM, Chandan Rajendra wrote:
> On Sunday, February 23, 2020 7:35 AM Allison Collins wrote:
>> This patch replaces the attribute name and length parameters with a single struct
>> xfs_name parameter. This helps to clean up the numbers of parameters being passed
>> around and pre-simplifies the code some.
>>
>
> I don't see any logical errors.
>
> Reviewed-by: Chandan Rajendra <chandanrlinux@gmail.com>
Alrighty, thank you!

Allison

>
>> Signed-off-by: Allison Collins <allison.henderson@oracle.com>
>> ---
>> fs/xfs/libxfs/xfs_attr.c | 22 +++++++++-------------
>> fs/xfs/libxfs/xfs_attr.h | 12 +++++-------
>> fs/xfs/libxfs/xfs_types.c | 11 +++++++++++
>> fs/xfs/libxfs/xfs_types.h | 1 +
>> fs/xfs/xfs_acl.c | 25 +++++++++++--------------
>> fs/xfs/xfs_ioctl.c | 23 +++++++++++++----------
>> fs/xfs/xfs_iops.c | 6 +++---
>> fs/xfs/xfs_xattr.c | 28 ++++++++++++++++------------
>> 8 files changed, 69 insertions(+), 59 deletions(-)
>>