From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs/270: use _scratch_xfs_set_metadata_field to fuzz rocompat bits
Date: Fri, 5 Oct 2018 14:54:27 +0800 [thread overview]
Message-ID: <5BB70AA3.6060000@cn.fujitsu.com> (raw)
In-Reply-To: <153869877319.26648.6762297729048228417.stgit@magnolia>
On 2018/10/05 8:19, Darrick J. Wong wrote:
> From: Darrick J. Wong<darrick.wong@oracle.com>
>
> Use the helper to set the metadata field so that we can bypass write
> verifier checks.
Hi Darrick,
When write command doesn't support -d option, xfs/270 with the patch
works well.
Reviewed-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Thanks,
Xiao Yang
> Signed-off-by: Darrick J. Wong<darrick.wong@oracle.com>
> ---
> tests/xfs/270 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/tests/xfs/270 b/tests/xfs/270
> index da66bc33..fb72ba7c 100755
> --- a/tests/xfs/270
> +++ b/tests/xfs/270
> @@ -44,8 +44,8 @@ _scratch_mkfs_xfs>>$seqres.full 2>&1
> # set the highest bit of features_ro_compat, use it as an unknown
> # feature bit. If one day this bit become known feature, please
> # change this case.
> -$XFS_DB_PROG -x -c "sb 0" -c "write -d features_ro_compat $((2**31))" \
> - $SCRATCH_DEV | grep -v "Allowing write of corrupted data"
> +_scratch_xfs_set_metadata_field "features_ro_compat" "$((2**31))" "sb 0" | \
> + grep 'features_ro_compat'
>
> # rw mount with unknown ro-compat feature should fail
> echo "rw mount test"
>
>
>
>
next prev parent reply other threads:[~2018-10-05 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 0:19 [PATCH 0/6] fstests: fixes and new tests Darrick J. Wong
2018-10-05 0:19 ` [PATCH 1/6] generic: add bfoster's alternate reproducer Darrick J. Wong
2018-10-05 0:19 ` [PATCH 2/6] xfs: test mount time summary counter check and fix Darrick J. Wong
2018-10-05 0:19 ` [PATCH 3/6] xfs/189: skip 'barrier' mount option test on newer kernels Darrick J. Wong
2018-10-05 0:19 ` [PATCH 4/6] xfs/270: use _scratch_xfs_set_metadata_field to fuzz rocompat bits Darrick J. Wong
2018-10-05 6:54 ` Xiao Yang [this message]
2018-10-05 0:19 ` [PATCH 5/6] xfs/288: shut up verifier error Darrick J. Wong
2018-10-05 0:19 ` [PATCH 6/6] generic: test reflink side effects Darrick J. Wong
2018-10-14 15:40 ` Eryu Guan
2018-10-15 18:57 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BB70AA3.6060000@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).