From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>, darrick <darrick.wong@oracle.com>,
Murphy Zhou <jencce.kernel@gmail.com>,
fstests <fstests@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] generic/554: test only copy to active swap file
Date: Wed, 26 Jun 2019 09:18:45 +0800 [thread overview]
Message-ID: <5D12C7F5.8050502@cn.fujitsu.com> (raw)
In-Reply-To: <CAOQ4uxgYApyiiSCWiCUJRgRoYYztMuON2d_mhLso-=DkqwNcbA@mail.gmail.com>
On 2019/06/25 18:35, Amir Goldstein wrote:
> On Tue, Jun 25, 2019 at 1:29 PM Yang Xu<xuyang2018.jy@cn.fujitsu.com> wrote:
>> on 2019/06/18 23:11, Darrick J. Wong wrote:
>>
>>> On Tue, Jun 18, 2019 at 11:02:42AM -0400, Theodore Ts'o wrote:
>>>> On Tue, Jun 18, 2019 at 12:16:45PM +0300, Amir Goldstein wrote:
>>>>> On Tue, Jun 18, 2019 at 12:02 PM Murphy Zhou<jencce.kernel@gmail.com> wrote:
>>>>>> Would you mind updating sha1 after it get merged to Linus tree?
>>>>>>
>>>>>> That would be helpful for people tracking this issue.
>>>>>>
>>>>> This is the commit id in linux-next and expected to stay the same
>>>>> when the fix is merged to Linus tree for 5.3.
>>>> When I talked to Darrick last week, that was *not* the sense I got
>>>> from him. It's not necessarily guaranteed to be stable just yet...
>>> Darrick hasn't gotten any complaints about the copy-file-range-fixes
>>> branch (which has been in for-next for a week now), so he thinks that
>>> commit id (a31713517dac) should be stable from here on out.
>>>
>>> (Note that doesn't guarantee that Linus will pull said branch...)
>>>
>>> --D
>> Hi Amir
>>
>> The kernel fix commit message is right? :-) Because when I backport this patch into 5.2.0-rc6+ kernel,
>> generic/554(553) also fails, it should be commit a5544984af4 (vfs: add missing checks to copy_file_range).
>> By the way, a31713517dac ("vfs: introduce generic_file_rw_checks()") doesn't check for immutable and swap file.
>>
>> I think we can change this message after the fix is merged to Linus tree for 5.3. What do you think about it?
> You are right. Documented commit is wrong.
> The correct commit in linux-next is:
> 96e6e8f4a68d ("vfs: add missing checks to copy_file_range")
>
> (Not sure where you got a5544984af4 from?)
I get a5544984af4 from Darrick.wong copy-file-range-fixes branch.
> Let's fix that after the commit is upstream.
>
> Obviously, you would need to backport the entire series and not just this
> one commit to stable kernel.
Yes. I got it.
> Thanks,
> Amir.
>
>
>
next prev parent reply other threads:[~2019-06-26 1:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 15:39 [PATCH v2 1/2] generic/553: fix test description Amir Goldstein
2019-06-11 15:39 ` [PATCH v2 2/2] generic/554: test only copy to active swap file Amir Goldstein
2019-06-11 15:41 ` Amir Goldstein
2019-06-11 15:59 ` Theodore Ts'o
2019-06-11 16:07 ` Amir Goldstein
2019-06-18 9:02 ` Murphy Zhou
2019-06-18 9:16 ` Amir Goldstein
2019-06-18 9:36 ` Murphy Zhou
2019-06-18 15:02 ` Theodore Ts'o
2019-06-18 15:11 ` Darrick J. Wong
2019-06-25 10:29 ` Yang Xu
2019-06-25 10:35 ` Amir Goldstein
2019-06-26 1:18 ` Yang Xu [this message]
2019-06-11 15:40 ` [PATCH v2 1/2] generic/553: fix test description Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D12C7F5.8050502@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=jencce.kernel@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).