[PATCH] mkfs: remove useless log options in usage

[PATCH] mkfs: remove useless log options in usage

[Yang Xu]

Since commit 2cf637cf(mkfs: remove logarithm based CLI options),
xfsprogs has discarded log options in node_options, remove it in usage.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 mkfs/xfs_mkfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index db3ad38e..91391b72 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -858,7 +858,7 @@ usage( void )
 			    (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
 			    sectsize=num\n\
 /* force overwrite */	[-f]\n\
-/* inode size */	[-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
+/* inode size */	[-i perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
 			    projid32bit=0|1,sparse=0|1]\n\
 /* no discard */	[-K]\n\
 /* log subvol */	[-l agnum=n,internal,size=num,logdev=xxx,version=n\n\
-- 
2.18.1

Re: [PATCH] mkfs: remove useless log options in usage

[Darrick J. Wong]

On Wed, Jun 12, 2019 at 05:09:35PM +0800, Yang Xu wrote:
> Since commit 2cf637cf(mkfs: remove logarithm based CLI options),
> xfsprogs has discarded log options in node_options, remove it in usage.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  mkfs/xfs_mkfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index db3ad38e..91391b72 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -858,7 +858,7 @@ usage( void )
>  			    (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
>  			    sectsize=num\n\
>  /* force overwrite */	[-f]\n\
> -/* inode size */	[-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> +/* inode size */	[-i perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
>  			    projid32bit=0|1,sparse=0|1]\n\
>  /* no discard */	[-K]\n\
>  /* log subvol */	[-l agnum=n,internal,size=num,logdev=xxx,version=n\n\
> -- 
> 2.18.1
> 
> 
> 

Re: [PATCH] mkfs: remove useless log options in usage

[Yang Xu]

on 2019/06/12 23:01, Darrick J. Wong wrote:

> On Wed, Jun 12, 2019 at 05:09:35PM +0800, Yang Xu wrote:
>> Since commit 2cf637cf(mkfs: remove logarithm based CLI options),
>> xfsprogs has discarded log options in node_options, remove it in usage.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> Looks ok,
> Reviewed-by: Darrick J. Wong<darrick.wong@oracle.com>
>
> --D
>
Hi sandeen

My patch missed for xfsprogs for-next branch 8bfb5eac.
By the way, the patch only removes useless log usage in inode option.
So I think we don't need to resubmit it again.

Thanks
Yang Xu


>> ---
>>   mkfs/xfs_mkfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
>> index db3ad38e..91391b72 100644
>> --- a/mkfs/xfs_mkfs.c
>> +++ b/mkfs/xfs_mkfs.c
>> @@ -858,7 +858,7 @@ usage( void )
>>   			    (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
>>   			    sectsize=num\n\
>>   /* force overwrite */	[-f]\n\
>> -/* inode size */	[-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
>> +/* inode size */	[-i perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
>>   			    projid32bit=0|1,sparse=0|1]\n\
>>   /* no discard */	[-K]\n\
>>   /* log subvol */	[-l agnum=n,internal,size=num,logdev=xxx,version=n\n\
>> -- 
>> 2.18.1
>>
>>
>>
>
>

Re: [PATCH] mkfs: remove useless log options in usage

[Eric Sandeen]

On 6/25/19 8:42 PM, Yang Xu wrote:
> on 2019/06/12 23:01, Darrick J. Wong wrote:
> 
>> On Wed, Jun 12, 2019 at 05:09:35PM +0800, Yang Xu wrote:
>>> Since commit 2cf637cf(mkfs: remove logarithm based CLI options),
>>> xfsprogs has discarded log options in node_options, remove it in usage.
>>>
>>> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
>> Looks ok,
>> Reviewed-by: Darrick J. Wong<darrick.wong@oracle.com>
>>
>> --D
>>
> Hi sandeen
> 
> My patch missed for xfsprogs for-next branch 8bfb5eac.
> By the way, the patch only removes useless log usage in inode option.
> So I think we don't need to resubmit it again.

Thanks for the reminder and sorry for missing it.  Funny, I tried to fix
this too but missed some ;)

I'll get it in the next push.

commit c66bd30ed7aecb429cfe3400c32892d7bc78e75b
Author: Eric Sandeen <sandeen@redhat.com>
Date:   Thu Jan 4 13:56:29 2018 -0600

    mkfs: un-document removed logarithm based CLI options
    
    Remove logarithm-based options from usage() and manpage.
    
    Fixes: 70f72d5 "mkfs: remove logarithm based CLI options"
    Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Eric Sandeen <sandeen@sandeen.net>