From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7CD362999 for ; Tue, 26 Aug 2025 15:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756222891; cv=none; b=cthJGFmWzfo+PdEEQ9ppAMJxwi9/JG+RCOhzl2UOxcZGQDXThudpo8eONKOy5eSu/b0sQpa8IAgeWL2ok8r7CR/8Fh303RKdq9P/qkqGQNsLPQNTSxLy82Dj3mIgV7rhVpNY1VmgUAu02DPtBcEBVfl6E9VAjbLsXcsJc9gftF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756222891; c=relaxed/simple; bh=7Rb0WDz6RNiTOxNcfVfw/tSky4eT2lKquvzMe9BAl6M=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FGMS1z/+seha8cD9rXKV4jVdHSWbF/AtHwHqja1elcWtz7qlvM2d4OBxaOmv95lgVmCYLOHqUdk1HoLbVYX6rwhsAsoy/FG9VC/Tv3fFeMLe/wZ/vwvhczM05/00Lgg59TkbTiSzNxd97eSDpcfhcPZSndBS1/jORoMe8ztUZ7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com; spf=none smtp.mailfrom=toxicpanda.com; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b=zEftBxnH; arc=none smtp.client-ip=209.85.219.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b="zEftBxnH" Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e931cad1fd8so4824444276.1 for ; Tue, 26 Aug 2025 08:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1756222888; x=1756827688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9pKHzHpITaAc/mjXTKQS2R/PEauqoOSV7l2KfBiByOc=; b=zEftBxnHOYqdJPVmTEXMYULPzm+1QQ1YN0kFgb3VDGK+z9TCCHC2njCjZoYJmPf0zI xZos5vZFx0pUPPuPWAFDp8hzx7eQDWWtj8TzNrfWp2vOukmRps/7etBdjP/fXKxYMG7y ZW9tl4+OOns9pZy6c3vgi8vCR7raxs+g5vXa3Xa7+8EyaOk7P8OASzrl7AkNWnzEs3ys /zdBiA0XBuwDWjDrKj/pP3n483Nnw9AzFAGis9z/mEVVv+XwXjfuVHlO7y6ZlN1aqCpk Iv9iz8/b36g46zQVGbEGYmombxLPIJZ0EDlY6DVBcyVnbJrNOH7Ghe63wJ6bPF3Dzqzk hOCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756222888; x=1756827688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9pKHzHpITaAc/mjXTKQS2R/PEauqoOSV7l2KfBiByOc=; b=D9g6y7C/xRcf9/x5z9h1MaSE8QVP4ARhzs7PItwHeUOmsGVgngWCfMn7rjrZaUU2o2 2KR2oq8bk6FaNVgmvEMQSakpmmhioiH4A+NsPX2hJW2PaBFE0/3y3sS1ImVPZY+2G62T 6RCgAAm2CBC+XGBGBeg7EJNr9Dv9Wp59BA+GYaq4kZljVt3wEFSxIMxLiOWUplmbEH2W vr1+Lz2kmwEJEzPrXYFt4cOJtg9bhVZvTt+yIbG8yPQmQ020jO7u0i0ta2zVRpnRK9oa WVI1SsNABy1EkL7rwcZYVnSFPqYCsnWaPmBXjPmHYMsQdYQHohxJq2bHmXmMSWlG/11n +3ow== X-Forwarded-Encrypted: i=1; AJvYcCUiQ6Iu8mqA5tpglX1wriuWrYssQtwOhl0yc+i5NhI4gKuvmLX8hJpajlV2AXejRXN6eLHrbjoETwg=@vger.kernel.org X-Gm-Message-State: AOJu0YwcNvUfEOHzhHYqggf85N+5yt5SGeOQbH5z2kw0M9kjUE8YSgW/ pGhEkR966k/AbtkTSrO7KCKtThlQkeAdpSjHfOncOFOoOM8s7H02HF1jJLEwtfhewfE= X-Gm-Gg: ASbGncu58pgeP9MGd3qyPNsHDTkdg5Gi4d80bWkZgaSF03hyfwF0S+aHGJ41C4GPJFQ lBtP7SCRjwIFFVj8RMybWylIFaWDzI+K/VMyrW2wIokugpzeo1jWbiVvf0Ff1t9354J1xgVhJSK lvyrBy//tFawPOOG7BSa36x+y5E+X5SdHwt0cTq/XMKrhbE0ZpRdVsd/Hl0j/DTC1LmGQOj56hg bfBiFTeJl8Iv8LOwqBvvsKQoh3IjWbqelkal6IizZsWOuVFe2YHYWFNv2JqZ10MkUVFtNwp54cO FjWVT+bcwwAGqX3OcuBAZAtZOCoS+VSL9L+fk0KzeOpT9AFCmRWi5t9K8WGG324d0X9blqht7ZG L3KSosnXJzm9Wx5yM2KAr87raOWOYTqE3dO70jRhtP3D8w6bAXBF0GzNcbaa7PwnyjnxQ/g== X-Google-Smtp-Source: AGHT+IHpeaJ39DrKl0SHq4TeALy48X7MoeQZe8JyD4wQTO8EFKaesDAqzHePbJNfnv8wB7k8ckcMHg== X-Received: by 2002:a05:6902:3483:b0:e95:3b7b:6e4e with SMTP id 3f1490d57ef6-e953b7b72d3mr8336972276.53.1756222887983; Tue, 26 Aug 2025 08:41:27 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e96ea63fab0sm169958276.8.2025.08.26.08.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 08:41:27 -0700 (PDT) From: Josef Bacik To: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, brauner@kernel.org, viro@ZenIV.linux.org.uk, amir73il@gmail.com Subject: [PATCH v2 27/54] fs: remove I_WILL_FREE|I_FREEING check from __inode_add_lru Date: Tue, 26 Aug 2025 11:39:27 -0400 Message-ID: <5b72bc52855034d68887e466dbf790d6c2a1a9eb.1756222465.git.josef@toxicpanda.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We only want to add to the LRU if the current caller is potentially the last one dropping a reference, so if our refcount is 0 we're being deleted, and if the refcount is > 1 then there is another ref holder and they can add the inode to the LRU list. Signed-off-by: Josef Bacik --- fs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index d34da95a3295..082addba546c 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -597,8 +597,6 @@ static void __inode_add_lru(struct inode *inode, bool rotate) lockdep_assert_held(&inode->i_lock); - if (inode->i_state & (I_FREEING | I_WILL_FREE)) - return; if (icount_read(inode) != 1) return; if (inode->__i_nlink == 0) -- 2.49.0