From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5FAC41513 for ; Mon, 7 Aug 2023 02:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbjHGCj4 (ORCPT ); Sun, 6 Aug 2023 22:39:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbjHGCjz (ORCPT ); Sun, 6 Aug 2023 22:39:55 -0400 Received: from out-71.mta1.migadu.com (out-71.mta1.migadu.com [IPv6:2001:41d0:203:375::47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40093E6A for ; Sun, 6 Aug 2023 19:39:53 -0700 (PDT) Message-ID: <5d44e45b-cb85-b878-f21d-d0b508c3b696@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691375991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hnInpweKZLBkHKIXgZGAhqJI9/CXpILz8h/AYQFzW0=; b=vbTvrcu/gFXyM8bRPaWFXDzALqidtwTte3s8rMZhmclzD9y3biLxbDlMe9x2GD2nQiE6J6 eitlvgNG0xPjLheVH431n30UgZADuq7DSTLvn4FhIdKUG8zXXx4YyIGbv0ZCsDHnh9gsSk msoj1iwQGXSHcqqbFVsL8iBF9Zuo6lA= Date: Mon, 7 Aug 2023 10:39:44 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 5.10 0/2] Fix xfs/179 for 5.10 stable Content-Language: en-US To: "Darrick J. Wong" , Greg KH Cc: amir73il@gmail.com, dchinner@redhat.com, yangx.jy@fujitsu.com, linux-xfs@vger.kernel.org, stable@vger.kernel.org References: <20230803093652.7119-1-guoqing.jiang@linux.dev> <20230804154757.GI11352@frogsfrogsfrogs> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang In-Reply-To: <20230804154757.GI11352@frogsfrogsfrogs> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 8/4/23 23:47, Darrick J. Wong wrote: > On Thu, Aug 03, 2023 at 05:36:50PM +0800, Guoqing Jiang wrote: >> Hi, >> >> With the two patches applied, xfs/179 can pass in 5.10.188. Otherwise I got >> >> [root@localhost xfstests]# ./check xfs/179 >> FSTYP -- xfs (non-debug) >> PLATFORM -- Linux/x86_64 localhost 5.10.188-default #14 SMP Thu Aug 3 15:23:19 CST 2023 >> MKFS_OPTIONS -- -f /dev/loop1 >> MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/loop1 /mnt/scratch >> >> xfs/179 1s ... [failed, exit status 1]- output mismatch (see /root/xfstests/results//xfs/179.out.bad) >> --- tests/xfs/179.out 2023-07-13 16:12:27.000000000 +0800 >> +++ /root/xfstests/results//xfs/179.out.bad 2023-08-03 16:55:38.173787911 +0800 >> @@ -8,3 +8,5 @@ >> Check scratch fs >> Remove reflinked files >> Check scratch fs >> +xfs_repair fails >> +(see /root/xfstests/results//xfs/179.full for details) >> ... >> (Run 'diff -u /root/xfstests/tests/xfs/179.out /root/xfstests/results//xfs/179.out.bad' to see the entire diff) >> >> HINT: You _MAY_ be missing kernel fix: >> b25d1984aa88 xfs: estimate post-merge refcounts correctly >> >> Ran: xfs/179 >> Failures: xfs/179 >> Failed 1 of 1 tests >> >> Please review if they are approriate for 5.10 stable. > Seems fine to me, but ... there is no maintainer for 5.10; is your > employer willing to support this LTS kernel? Hi Darrick, Thanks for your review! I think Amir is the maintainer for 5.10 😉. I can help if needed since our kernel is heavily based on 5.10 stable. We also run tests against 5.10 stable, that is why I send fixes patches for it. Hi Greg, Could you consider add the two to your list? Thank you! Regards, Guoqing