From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-146.mta1.migadu.com [95.215.58.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34CE042901E for ; Thu, 24 Sep 2026 07:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790234734; cv=none; b=M9wsY1yImiCiUJ8UIXW9lAL6ng5SnzZrHCsp8ER8jHRQRbMjE2L3DN0GEiwT4URxPUJLcw8dIvHN4Mr2IfsVY7Dr9K9qxNFoUv2rhaxsvh07vq8tpArXWcopQpO5QfcwgjbJQadLRzjK+cjUbs1kgPIEMD4tnhDMt9dW15CdtjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790234734; c=relaxed/simple; bh=kpxnQ+T5dm8y5ACvCTrDn+fdvTMPwnbCt6gITaWVTuo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BX2eHc8XMvNroEFFCpkXZTJgVRwWXBAkNo6Q/CiYxn+fve5Y25lQT4bjpM0qgZkymSEIYqemOznqvaG6ZZQZDH4/ft8rkF7olzTSYRyywfboe1j00jaTuILUv6geBcxWldGr4vBzBWd6qwJpy17+uBHJCOsi8Sz3jm+9RFYbOIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=pJN41egy; arc=none smtp.client-ip=95.215.58.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="pJN41egy" X-Envelope-To: linux-xfs@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=kpxnQ+T5dm8y5ACvCTrDn+fdvTMPwnbCt6gITaWVTuo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790234729; v=1; x=1790839529; b=pJN41egyVCryAaV6ao9m7YngC4qBSQsCnSPCGMrCjfd6tFfw0q20VZ31s30Ye9zIc7yWVyui sOiOfuxeE3FtwultfeAPQvHD8yErRlneQ40YwcS7asSsFKEQyc94rdlK5R0urLX3GEP5o1/hvx9 Bej49lTUUweUId8U2iTQ7QIY= X-Envelope-To: linux-xfs@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 61f703b09c6c258b; Thu, 24 Sep 2026 07:25:07 +0000 X-Mizu-Trace-ID: 61f703b09c6c258b X-Migadu-Flow: FLOW_OUT Message-ID: <5ded31ca-fabf-4492-ab5f-75cf43118714@linux.dev> Date: Thu, 24 Sep 2026 08:25:02 +0100 Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 7/9] iomap: reject atomic writes in iomap_file_buffered_write() To: Tal Zussman , Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Luis Chamberlain , Hannes Reinecke , "Matthew Wilcox (Oracle)" , Christian Brauner , "Darrick J. Wong" , Keith Busch , "Martin K. Petersen" Cc: Shin'ichiro Kawasaki , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20260923-blkdev-fixes-v5-0-89e60d66eb38@columbia.edu> <20260923-blkdev-fixes-v5-7-89e60d66eb38@columbia.edu> Content-Language: en-US From: John Garry In-Reply-To: <20260923-blkdev-fixes-v5-7-89e60d66eb38@columbia.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/24/26 00:56, Tal Zussman wrote: > Buffered atomic writes are not currently supported. The page cache > writes folios back independently, so it cannot guarantee that a range is > written atomically. iomap_file_buffered_write() does not check for > IOCB_ATOMIC, so a direct write that falls back to it would complete an > atomic write without atomicity. While no such case currently exists, > fail IOCB_ATOMIC writes with -EOPNOTSUPP, so that a future fallback > cannot complete an atomic write non-atomically. > > Suggested-by: John Garry > Signed-off-by: Tal Zussman Reviewed-by: John Garry > --- > fs/iomap/buffered-io.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 0a5ebfda90f1..e6654cfe1cbf 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -1304,6 +1304,10 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i, > }; > ssize_t ret; > > + /* Buffered atomic writes are not supported */ > + if (iocb->ki_flags & IOCB_ATOMIC) > + return -EOPNOTSUPP; > + > if (iocb->ki_flags & IOCB_NOWAIT) > iter.flags |= IOMAP_NOWAIT; > if (iocb->ki_flags & IOCB_DONTCACHE) >