From: nscott@aconex.com
To: Andi Kleen <ak@suse.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] XFS bitops to Linux again
Date: Thu, 4 Oct 2007 08:58:11 +1000 (EST) [thread overview]
Message-ID: <60338.192.168.3.1.1191452291.squirrel@mail.aconex.com> (raw)
In-Reply-To: <200710040027.16926.ak@suse.de>
>
> This time against CVS
>
> Replace XFS bit functions with call Linux functions
>
> XFS had some own functions to find high and low bits.
>
> This patch replaces them with a call to the respective Linux functions.
> The semantics of the Linux functions differ a little, but i checked
> all call sites that they can deal with that.
Several of these call sites are also compiled in userspace in libxfs. It
would
be a good idea from that POV also to keep some level of abstraction so that
these calls can be mapped to userspace routines as well.
> The resulting xfs.ko is about 500 bytes smaller on x86-64
Thats it? To be honest, this sounds like just code churn and risk
introduction.
What testing was done? Changes to some of these routines has introuced
subtle log recovery bugs in the past - has recovery been tested at all?
The QA
suite has some log recovery tests, it'd be a good idea to verify with those..
cheers.
--
Nathan
next prev parent reply other threads:[~2007-10-03 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 22:27 [PATCH] XFS bitops to Linux again Andi Kleen
2007-10-03 22:58 ` nscott [this message]
2007-10-04 8:14 ` Andi Kleen
2007-10-04 13:11 ` Eric Sandeen
2007-10-04 20:42 ` nscott
2007-10-04 21:10 ` Eric Sandeen
2007-10-04 23:08 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60338.192.168.3.1.1191452291.squirrel@mail.aconex.com \
--to=nscott@aconex.com \
--cc=ak@suse.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox