public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Lachlan McIlroy <lmcilroy@redhat.com>
To: John Quigley <jquigley@jquigley.com>
Cc: XFS Development <xfs@oss.sgi.com>
Subject: Re: XFS corruption with failover
Date: Tue, 18 Aug 2009 22:18:12 -0400 (EDT)	[thread overview]
Message-ID: <606994882.2142291250648292843.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <990461759.2142271250648177725.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>

----- "John Quigley" <jquigley@jquigley.com> wrote:

> Lachlan McIlroy wrote:
> > If that fails too can you run xfs_logprint on /dev/sde and
> > post any errors it reports?
> 
> My apologies for the delayed response; output of logprint can be
> downloaded as a ~4MB bzip:
> 
> http://www.jquigley.com/files/tmp/xfs-failover-logprint.bz2

xfs_logprint doesn't find any problems with this log but that doesn't mean
the kernel doesn't - they use different implementations to read the log.  I
noticed that the active part of the log wraps around the physical end/start
of the log which reminds of this fix:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d1afb678ce77b930334a8a640a05b8e68178a377

I remember that without this fix we were seeing ASSERTs in the log recovery
code - unfortunately I don't remember exactly where but it could be from
the same location you are getting the "bad clientid" error.  When a log
record wraps the end/start of the physical log we need to do two I/Os to
read the log record in.  This bug caused the second read to go to an
incorrect location in the buffer which overwrote part of the first I/O and
corrupted the log record.  I think the fix made it into 2.6.24.

> 
> Thanks very much for your consideration.
> 
> - John Quigley
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

       reply	other threads:[~2009-08-19  2:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <990461759.2142271250648177725.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-19  2:18 ` Lachlan McIlroy [this message]
2009-08-19 15:46   ` XFS corruption with failover John Quigley
2009-08-23 18:17     ` XFS corruption with power failure John Quigley
2009-08-26 17:54       ` John Quigley
2009-09-01 18:13         ` Christoph Hellwig
2009-09-15 15:50           ` John Quigley
2009-09-17 18:35             ` Christoph Hellwig
2009-09-01 19:17       ` John Quigley
     [not found] <1194138654.75921250838215929.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-21  7:11 ` XFS corruption with failover Lachlan McIlroy
     [not found] <835473717.1935811250214078456.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-14  1:43 ` Lachlan McIlroy
     [not found] <424153067.1934481250210293891.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-14  0:38 ` Lachlan McIlroy
2009-08-14  1:14   ` John Quigley
2009-08-17 18:04   ` John Quigley
2009-08-13 20:17 John Quigley
2009-08-13 21:17 ` Emmanuel Florac
2009-08-13 22:42   ` Felix Blyakher
2009-08-14  0:52     ` John Quigley
2009-08-14  0:50   ` John Quigley
2009-08-13 21:44 ` Felix Blyakher
2009-08-14  0:31   ` Eric Sandeen
2009-08-14  0:58     ` Lachlan McIlroy
2009-08-14  1:35       ` Eric Sandeen
2009-08-14  1:44         ` John Quigley
2009-08-14  1:06     ` John Quigley
2009-08-14 13:21     ` Felix Blyakher
2009-08-14  0:56   ` John Quigley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=606994882.2142291250648292843.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com \
    --to=lmcilroy@redhat.com \
    --cc=jquigley@jquigley.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox