From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfsprogs: fix build dep on configure.ac
Date: Wed, 5 Apr 2017 09:02:57 -0500 [thread overview]
Message-ID: <630ee329-e906-2673-926f-4fea0971bd46@redhat.com> (raw)
Zorro reported that this sequence:
# git checkout v4.9.0; make realclean; make
# git checkout v4.10.0; make clean; make
fails:
...
Building libxfs
[CC] gen_crc32table
gcc: error: @BUILD_CFLAGS@: No such file or directory
gmake[3]: *** No rule to make target `crc32table.h', needed by `crc32selftest'. Stop.
This is because
0a71e38 build: Allow compiling xfsprogs in a cross compile environment
added the new BUILD_CFLAGS to configure.ac, and unless we re-run
autotools, that variable does not get substituted when
include/builddefs gets built.
(This can be worked around by "make realclean" and then everything
gets regenerated.)
The configure script is generated from configure.ac, so adding
a Make dependency here should resolve such issues in the future.
Reported-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
(I'm no build/Make guru, but I think this is sane...)
diff --git a/Makefile b/Makefile
index 6e45733..ba87327 100644
--- a/Makefile
+++ b/Makefile
@@ -101,7 +101,7 @@ endif
# versions will copy those files anyway, and don't understand -i.
LIBTOOLIZE_INSTALL = `$(LIBTOOLIZE_BIN) -n -i >/dev/null 2>/dev/null && echo -i`
-configure:
+configure: configure.ac
$(LIBTOOLIZE_BIN) -c $(LIBTOOLIZE_INSTALL) -f
cp include/install-sh .
aclocal -I m4
next reply other threads:[~2017-04-05 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 14:02 Eric Sandeen [this message]
2017-04-05 18:08 ` [PATCH] xfsprogs: fix build dep on configure.ac Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630ee329-e906-2673-926f-4fea0971bd46@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox