From: Dan Williams <dan.j.williams@intel.com>
To: Eric Sandeen <sandeen@sandeen.net>,
Chandan Babu R <chandanbabu@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <david@fromorbit.com>, <linux-xfs@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <dan.j.williams@intel.com>
Subject: Re: [PATCH] xfs: drop experimental warning for FSDAX
Date: Fri, 29 Sep 2023 11:28:02 -0700 [thread overview]
Message-ID: <65171732329c4_c558e2946a@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <4c985608-39f6-1a6e-ec95-42d7c3581d8d@sandeen.net>
Eric Sandeen wrote:
> On 9/29/23 9:17 AM, Chandan Babu R wrote:
> > On Thu, Sep 28, 2023 at 09:20:52 AM -0700, Andrew Morton wrote:
> >> On Thu, 28 Sep 2023 16:44:00 +0800 Shiyang Ruan <ruansy.fnst@fujitsu.com> wrote:
> >>
> >>> But please pick the following patch[1] as well, which fixes failures of
> >>> xfs55[0-2] cases.
> >>>
> >>> [1]
> >>> https://lore.kernel.org/linux-xfs/20230913102942.601271-1-ruansy.fnst@fujitsu.com
> >>
> >> I guess I can take that xfs patch, as it fixes a DAX patch. I hope the xfs team
> >> are watching.
> >>
> >> But
> >>
> >> a) I'm not subscribed to linux-xfs and
> >>
> >> b) the changelog fails to describe the userspace-visible effects of
> >> the bug, so I (and others) are unable to determine which kernel
> >> versions should be patched.
> >>
> >> Please update that changelog and resend?
> >
> > I will apply "xfs: correct calculation for agend and blockcount" patch to
> > xfs-linux Git tree and include it for the next v6.6 pull request to Linus.
> >
> > At the outset, It looks like I can pick "mm, pmem, xfs: Introduce
> > MF_MEM_PRE_REMOVE for unbind"
> > (i.e. https://lore.kernel.org/linux-xfs/20230928103227.250550-1-ruansy.fnst@fujitsu.com/T/#u)
> > patch for v6.7 as well. But that will require your Ack. Please let me know
> > your opinion.
> >
> > Also, I will pick "xfs: drop experimental warning for FSDAX" patch for v6.7.
>
> While I hate to drag it out even longer, it seems slightly optimistic to
> drop experimental at the same time as the "last" fix, in case it's not
> really the last fix.
>
> But I don't have super strong feelings about it, and I would be happy to
> finally see experimental go away. So if those who are more tuned into
> the details are comfortable with that 6.7 plan, I'll defer to them on
> the question.
The main blockage of "experimental" was the inability to specify
dax+reflink, and the concern that resolving that conflict would end up
breaking MAP_SYNC semantics or some other regression.
The dax_notify_failure() work has resolved that conflict without
regressing semantics.
Ultimately this is an XFS filesystem maintainer decision, but my
perspective is that v6.7-rc1 starts the clock on experimental going away
and if the bug reports stay quiet that state can persist into
v6.7-final. If new reports crop up, revert the experimental removal and
try again for v6.8.
next prev parent reply other threads:[~2023-09-29 20:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 6:38 [PATCH] xfs: drop experimental warning for FSDAX Shiyang Ruan
2023-09-21 8:33 ` Shiyang Ruan
2023-09-26 14:55 ` Darrick J. Wong
2023-09-27 1:18 ` Dave Chinner
2023-09-27 1:46 ` Darrick J. Wong
2023-09-27 3:38 ` Chandan Babu R
2023-09-27 5:17 ` Shiyang Ruan
2023-09-27 6:38 ` Shiyang Ruan
2023-09-27 7:31 ` Chandan Babu R
2023-09-27 15:30 ` Andrew Morton
2023-09-28 8:44 ` Shiyang Ruan
2023-09-28 16:20 ` Andrew Morton
2023-09-28 17:13 ` Darrick J. Wong
2023-09-29 11:56 ` Shiyang Ruan
2023-09-29 18:34 ` Dan Williams
2023-10-02 12:15 ` Shiyang Ruan
2023-10-02 12:39 ` Chandan Babu R
2023-10-05 0:08 ` Darrick J. Wong
2023-10-05 8:53 ` Shiyang Ruan
2023-10-05 16:05 ` Darrick J. Wong
2023-10-09 14:14 ` Shiyang Ruan
2023-10-09 16:47 ` Darrick J. Wong
2023-10-10 3:53 ` Shiyang Ruan
2023-10-10 17:51 ` Darrick J. Wong
2023-09-29 14:17 ` Chandan Babu R
2023-09-29 14:35 ` Eric Sandeen
2023-09-29 15:27 ` Chandan Babu R
2023-09-29 18:28 ` Dan Williams [this message]
2023-10-04 17:50 ` Darrick J. Wong
2024-01-11 16:59 ` Bill O'Donnell
2024-01-12 2:21 ` Darrick J. Wong
2024-02-23 7:28 ` Shiyang Ruan
2024-02-26 16:58 ` Dan Williams
2024-02-27 9:50 ` Shiyang Ruan
2024-02-23 17:32 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65171732329c4_c558e2946a@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chandanbabu@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).