* [PATCH] xfs: trace ATTR flags in xattr tracepoints
@ 2018-04-17 20:03 Eric Sandeen
2018-04-18 0:37 ` Darrick J. Wong
2018-04-18 10:28 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2018-04-17 20:03 UTC (permalink / raw)
To: linux-xfs
This will trace i.e. the ATTR_SECURE/ATTR_CREATE/ATTR_REPLACE
flags as well as the OP_FLAGS.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 8955254..b03a0f4 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -1750,6 +1750,7 @@
__field(int, namelen)
__field(int, valuelen)
__field(xfs_dahash_t, hashval)
+ __field(int, flags)
__field(int, op_flags)
),
TP_fast_assign(
@@ -1760,10 +1761,11 @@
__entry->namelen = args->namelen;
__entry->valuelen = args->valuelen;
__entry->hashval = args->hashval;
+ __entry->flags = args->flags;
__entry->op_flags = args->op_flags;
),
TP_printk("dev %d:%d ino 0x%llx name %.*s namelen %d valuelen %d "
- "hashval 0x%x op_flags %s",
+ "hashval 0x%x flags %s op_flags %s",
MAJOR(__entry->dev), MINOR(__entry->dev),
__entry->ino,
__entry->namelen,
@@ -1771,6 +1773,7 @@
__entry->namelen,
__entry->valuelen,
__entry->hashval,
+ __print_flags(__entry->flags, "|", XFS_ATTR_FLAGS),
__print_flags(__entry->op_flags, "|", XFS_DA_OP_FLAGS))
)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: trace ATTR flags in xattr tracepoints
2018-04-17 20:03 [PATCH] xfs: trace ATTR flags in xattr tracepoints Eric Sandeen
@ 2018-04-18 0:37 ` Darrick J. Wong
2018-04-18 10:28 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-04-18 0:37 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Tue, Apr 17, 2018 at 03:03:32PM -0500, Eric Sandeen wrote:
> This will trace i.e. the ATTR_SECURE/ATTR_CREATE/ATTR_REPLACE
> flags as well as the OP_FLAGS.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok, will pick up for 4.18.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> index 8955254..b03a0f4 100644
> --- a/fs/xfs/xfs_trace.h
> +++ b/fs/xfs/xfs_trace.h
> @@ -1750,6 +1750,7 @@
> __field(int, namelen)
> __field(int, valuelen)
> __field(xfs_dahash_t, hashval)
> + __field(int, flags)
> __field(int, op_flags)
> ),
> TP_fast_assign(
> @@ -1760,10 +1761,11 @@
> __entry->namelen = args->namelen;
> __entry->valuelen = args->valuelen;
> __entry->hashval = args->hashval;
> + __entry->flags = args->flags;
> __entry->op_flags = args->op_flags;
> ),
> TP_printk("dev %d:%d ino 0x%llx name %.*s namelen %d valuelen %d "
> - "hashval 0x%x op_flags %s",
> + "hashval 0x%x flags %s op_flags %s",
> MAJOR(__entry->dev), MINOR(__entry->dev),
> __entry->ino,
> __entry->namelen,
> @@ -1771,6 +1773,7 @@
> __entry->namelen,
> __entry->valuelen,
> __entry->hashval,
> + __print_flags(__entry->flags, "|", XFS_ATTR_FLAGS),
> __print_flags(__entry->op_flags, "|", XFS_DA_OP_FLAGS))
> )
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: trace ATTR flags in xattr tracepoints
2018-04-17 20:03 [PATCH] xfs: trace ATTR flags in xattr tracepoints Eric Sandeen
2018-04-18 0:37 ` Darrick J. Wong
@ 2018-04-18 10:28 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2018-04-18 10:28 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-18 10:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-17 20:03 [PATCH] xfs: trace ATTR flags in xattr tracepoints Eric Sandeen
2018-04-18 0:37 ` Darrick J. Wong
2018-04-18 10:28 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).