From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, alex@zadara.com
Subject: Re: [PATCH 1/6] mkfs: check root inode location
Date: Thu, 30 Jan 2020 14:34:14 -0600 [thread overview]
Message-ID: <6863f2cf-1c97-c024-e18c-25bbe4205ceb@sandeen.net> (raw)
In-Reply-To: <20200130201917.GD3447196@magnolia>
On 1/30/20 2:19 PM, Darrick J. Wong wrote:
> On Thu, Jan 30, 2020 at 01:32:30PM -0600, Eric Sandeen wrote:
>> On 1/23/20 6:17 PM, Darrick J. Wong wrote:
>>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>>
>>> Make sure the root inode gets created where repair thinks it should be
>>> created.
>>
>> Actual mkfs-time location calculation is still completely separate from
>> the code in xfs_ialloc_calc_rootino though, right? Maybe there's nothing
>> to do about that.
>
> Correct, because proto.c uses the regular inode allocation routines to
> create the root inode, and mkfs doesn't have the ability to compute the
> root inode and Make It So.
>
>> I mostly find myself wondering what a user will do next if this check fails.
>
> Complain. :)
>
> To be fair, if there was a mismatch prior to this patch, the user would
> end up with a filesystem that formats fine, mounts ok, and explodes in
> xfs_repair. Better we fail early than have repair shred the filesystem
> after they've loaded up their production data and deleted the backups.
Oh, for sure. But it's still:
"haha something went wrong, HAND PLONK"
I guess the savvy user would come to the list or file a bug.
(Hm, you know, a routine to dump cfg-> out for debugging would be neat.)
-Eric
next prev parent reply other threads:[~2020-01-30 20:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 0:17 [PATCH v3 0/6] xfs_repair: do not trash valid root dirs Darrick J. Wong
2020-01-24 0:17 ` [PATCH 1/6] mkfs: check root inode location Darrick J. Wong
2020-01-30 19:32 ` Eric Sandeen
2020-01-30 20:19 ` Darrick J. Wong
2020-01-30 20:34 ` Eric Sandeen [this message]
2020-01-24 0:17 ` [PATCH 2/6] xfs_repair: enforce that inode btree chunks can't point to AG headers Darrick J. Wong
2020-01-30 19:38 ` Eric Sandeen
2020-01-30 20:26 ` Darrick J. Wong
2020-01-30 20:46 ` Eric Sandeen
2020-01-24 0:17 ` [PATCH 3/6] xfs_repair: refactor fixed inode location checks Darrick J. Wong
2020-01-30 19:45 ` Eric Sandeen
2020-01-30 19:52 ` Eric Sandeen
2020-01-24 0:17 ` [PATCH 4/6] xfs_repair: use libxfs function to calculate root inode location Darrick J. Wong
2020-01-30 19:48 ` Eric Sandeen
2020-01-24 0:17 ` [PATCH 5/6] xfs_repair: check plausibility of root dir pointer before trashing it Darrick J. Wong
2020-01-30 20:18 ` Eric Sandeen
2020-01-30 20:34 ` Darrick J. Wong
2020-01-30 20:41 ` Eric Sandeen
2020-01-30 20:50 ` Darrick J. Wong
2020-01-24 0:18 ` [PATCH 6/6] xfs_repair: try to correct sb_unit value from secondaries Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-01-01 1:20 [PATCH v2 0/6] xfs_repair: do not trash valid root dirs Darrick J. Wong
2020-01-01 1:20 ` [PATCH 1/6] mkfs: check root inode location Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6863f2cf-1c97-c024-e18c-25bbe4205ceb@sandeen.net \
--to=sandeen@sandeen.net \
--cc=alex@zadara.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox