From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F00C47254 for ; Tue, 5 May 2020 23:40:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9921A206B8 for ; Tue, 5 May 2020 23:40:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="s6bewlhR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729332AbgEEXke (ORCPT ); Tue, 5 May 2020 19:40:34 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:43890 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727895AbgEEXkd (ORCPT ); Tue, 5 May 2020 19:40:33 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 045Nc285020419; Tue, 5 May 2020 23:40:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=oORBmMuYaNe/vKncdERCVuYfhrrS7jBpwjCXeM+MBaY=; b=s6bewlhRRmj2cDhkGydRGR/RewPd8zz2vKbeX71EYXx+UrpuUZ4zPiq21i/eRj9GBpjh h9EisayIExRMvrBvrh3G8amYkrsRAbXFCZBJ2K3jzfryl23X8WedVgqXpkT/w7DBAcvp dvzzD5O323H1gZBiiD8Rv305s1+eBVg13fzOfX4MZ33yhnZk0CMec58bBQ/Bd76Yb9vI C/EkgCokC/hlhSbiGhBMLYZmh1Iht6ywn2Eoi3esRImqDMaQOueednNUrpAui/oqvLXF 8gad7xbWiGXqFDlpsP+MDGJidgXKiQWlK+nXl6K9BBsV3xhzM4n6PCgy0X4zx1VhtB+Z vg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 30s09r7jxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 May 2020 23:40:30 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 045Nap1t039901; Tue, 5 May 2020 23:40:29 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 30sjdu3c43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 May 2020 23:40:29 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 045NeSDw029447; Tue, 5 May 2020 23:40:28 GMT Received: from [192.168.1.223] (/67.1.142.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 May 2020 16:40:28 -0700 Subject: Re: [PATCH v4 17/17] xfs: remove unused iget_flags param from xfs_imap_to_bp() To: Brian Foster , linux-xfs@vger.kernel.org References: <20200504141154.55887-1-bfoster@redhat.com> <20200504141154.55887-18-bfoster@redhat.com> From: Allison Collins Message-ID: <6a8cbce8-e33a-bdde-ad99-09a975a9184f@oracle.com> Date: Tue, 5 May 2020 16:40:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200504141154.55887-18-bfoster@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9612 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005050178 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9612 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=999 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005050178 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 5/4/20 7:11 AM, Brian Foster wrote: > iget_flags is unused in xfs_imap_to_bp(). Remove the parameter and > fix up the callers. > > Signed-off-by: Brian Foster > Reviewed-by: Darrick J. Wong > Reviewed-by: Christoph Hellwig Ok, looks fine to me Reviewed-by: Allison Collins > --- > fs/xfs/libxfs/xfs_inode_buf.c | 5 ++--- > fs/xfs/libxfs/xfs_inode_buf.h | 2 +- > fs/xfs/scrub/ialloc.c | 3 +-- > fs/xfs/xfs_inode.c | 7 +++---- > fs/xfs/xfs_log_recover.c | 2 +- > 5 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c > index b102e611bf54..81a010422bea 100644 > --- a/fs/xfs/libxfs/xfs_inode_buf.c > +++ b/fs/xfs/libxfs/xfs_inode_buf.c > @@ -161,8 +161,7 @@ xfs_imap_to_bp( > struct xfs_imap *imap, > struct xfs_dinode **dipp, > struct xfs_buf **bpp, > - uint buf_flags, > - uint iget_flags) > + uint buf_flags) > { > struct xfs_buf *bp; > int error; > @@ -621,7 +620,7 @@ xfs_iread( > /* > * Get pointers to the on-disk inode and the buffer containing it. > */ > - error = xfs_imap_to_bp(mp, tp, &ip->i_imap, &dip, &bp, 0, iget_flags); > + error = xfs_imap_to_bp(mp, tp, &ip->i_imap, &dip, &bp, 0); > if (error) > return error; > > diff --git a/fs/xfs/libxfs/xfs_inode_buf.h b/fs/xfs/libxfs/xfs_inode_buf.h > index 9b373dcf9e34..d9b4781ac9fd 100644 > --- a/fs/xfs/libxfs/xfs_inode_buf.h > +++ b/fs/xfs/libxfs/xfs_inode_buf.h > @@ -48,7 +48,7 @@ struct xfs_imap { > > int xfs_imap_to_bp(struct xfs_mount *, struct xfs_trans *, > struct xfs_imap *, struct xfs_dinode **, > - struct xfs_buf **, uint, uint); > + struct xfs_buf **, uint); > int xfs_iread(struct xfs_mount *, struct xfs_trans *, > struct xfs_inode *, uint); > void xfs_dinode_calc_crc(struct xfs_mount *, struct xfs_dinode *); > diff --git a/fs/xfs/scrub/ialloc.c b/fs/xfs/scrub/ialloc.c > index 64c217eb06a7..6517d67e8d51 100644 > --- a/fs/xfs/scrub/ialloc.c > +++ b/fs/xfs/scrub/ialloc.c > @@ -278,8 +278,7 @@ xchk_iallocbt_check_cluster( > &XFS_RMAP_OINFO_INODES); > > /* Grab the inode cluster buffer. */ > - error = xfs_imap_to_bp(mp, bs->cur->bc_tp, &imap, &dip, &cluster_bp, > - 0, 0); > + error = xfs_imap_to_bp(mp, bs->cur->bc_tp, &imap, &dip, &cluster_bp, 0); > if (!xchk_btree_xref_process_error(bs->sc, bs->cur, 0, &error)) > return error; > > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > index e0d9a5bf7507..4f915b91b9fd 100644 > --- a/fs/xfs/xfs_inode.c > +++ b/fs/xfs/xfs_inode.c > @@ -2172,7 +2172,7 @@ xfs_iunlink_update_inode( > > ASSERT(xfs_verify_agino_or_null(mp, agno, next_agino)); > > - error = xfs_imap_to_bp(mp, tp, &ip->i_imap, &dip, &ibp, 0, 0); > + error = xfs_imap_to_bp(mp, tp, &ip->i_imap, &dip, &ibp, 0); > if (error) > return error; > > @@ -2302,7 +2302,7 @@ xfs_iunlink_map_ino( > return error; > } > > - error = xfs_imap_to_bp(mp, tp, imap, dipp, bpp, 0, 0); > + error = xfs_imap_to_bp(mp, tp, imap, dipp, bpp, 0); > if (error) { > xfs_warn(mp, "%s: xfs_imap_to_bp returned error %d.", > __func__, error); > @@ -3665,8 +3665,7 @@ xfs_iflush( > * If we get any other error, we effectively have a corruption situation > * and we cannot flush the inode. Abort the flush and shut down. > */ > - error = xfs_imap_to_bp(mp, NULL, &ip->i_imap, &dip, &bp, XBF_TRYLOCK, > - 0); > + error = xfs_imap_to_bp(mp, NULL, &ip->i_imap, &dip, &bp, XBF_TRYLOCK); > if (error == -EAGAIN) { > xfs_ifunlock(ip); > return error; > diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c > index 11c3502b07b1..6a98fd9f00b3 100644 > --- a/fs/xfs/xfs_log_recover.c > +++ b/fs/xfs/xfs_log_recover.c > @@ -4987,7 +4987,7 @@ xlog_recover_process_one_iunlink( > /* > * Get the on disk inode to find the next inode in the bucket. > */ > - error = xfs_imap_to_bp(mp, NULL, &ip->i_imap, &dip, &ibp, 0, 0); > + error = xfs_imap_to_bp(mp, NULL, &ip->i_imap, &dip, &ibp, 0); > if (error) > goto fail_iput; > >