Re: [PATCH v5 09/14] xfs: Factor up trans roll from xfs_attr3_leaf_setflag

Christoph Hellwig
2019-12-24T12:26:46Z

> @@ -2854,10 +2854,7 @@ xfs_attr3_leaf_setflag(
> XFS_DA_LOGRANGE(leaf, name_rmt, sizeof(*name_rmt)));
> }
>
> - /*
> - * Commit the flag value change and start the next trans in series.
> - */
> - return xfs_trans_roll_inode(&args->trans, args->dp);
> + return error;

error is always 0 here.