Re: [PATCH v5 07/14] xfs: Factor out xfs_attr_leaf_addname helper

Christoph Hellwig
2019-12-24T12:22:56Z

On Wed, Dec 11, 2019 at 09:15:06PM -0700, Allison Collins wrote:
> Factor out new helper function xfs_attr_leaf_try_add.
> Because new delayed attribute routines cannot roll
> transactions, we carve off the parts of
> xfs_attr_leaf_addname that we can use. This will help
> to reduce repetitive code later when we introduce
> delayed attributes.

I have a hard time relating the subject to what is happening here,
maybe because the patch does too many things at once. One thing
is plitting a xfs_attr_leaf_try_add from xfs_attr_leaf_addname, which
seems pretty sensible, but then it also moves code from
xfs_attr_node_addname into the only caller. That probably should be
a separate patch with a proper description.