From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: log proper length of btree block in scrub/repair
Date: Fri, 30 Aug 2019 09:36:13 -0500 [thread overview]
Message-ID: <777aa8d3-fee7-d4b3-9a84-4d42e875127a@redhat.com> (raw)
In-Reply-To: <20190829082618.GB18614@infradead.org>
On 8/29/19 3:26 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 02:17:36PM -0500, Eric Sandeen wrote:
>> xfs_trans_log_buf() takes a final argument of the last byte to
>> log in the buffer; b_length is in basic blocks, so this isn't
>> the correct last byte. Fix it.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> just found by inspection/pattern matching, not tested TBH...
>
> Looks good. And I wonder if we should fix the interface instead,
> as it seems to lead to convoluted coe in just about every caller.
Yup, I had considered that too.
-Eric
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
next prev parent reply other threads:[~2019-08-30 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 19:17 [PATCH] xfs: log proper length of btree block in scrub/repair Eric Sandeen
2019-08-27 23:29 ` Dave Chinner
2019-08-29 8:26 ` Christoph Hellwig
2019-08-30 14:36 ` Eric Sandeen [this message]
2019-08-29 21:31 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777aa8d3-fee7-d4b3-9a84-4d42e875127a@redhat.com \
--to=sandeen@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox