From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:60140 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727804AbfEHFtG (ORCPT ); Wed, 8 May 2019 01:49:06 -0400 Date: Wed, 8 May 2019 01:49:04 -0400 (EDT) From: Pankaj Gupta Message-ID: <7976014.27184867.1557294544901.JavaMail.zimbra@redhat.com> In-Reply-To: <20190507161736.GV5207@magnolia> References: <20190426050039.17460-1-pagupta@redhat.com> <20190426050039.17460-7-pagupta@redhat.com> <20190507161736.GV5207@magnolia> Subject: Re: [Qemu-devel] [PATCH v7 6/6] xfs: disable map_sync for async flush MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: Dan Williams , Jan Kara , KVM list , "Michael S. Tsirkin" , Jason Wang , david , Qemu Developers , virtualization@lists.linux-foundation.org, Andreas Dilger , Ross Zwisler , Andrea Arcangeli , Dave Jiang , linux-nvdimm , Vishal L Verma , David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Linux ACPI , jmoyer , linux-ext4 , Len Brown , kilobyte@angband.pl, Rik van Riel , yuval shaia , Stefan Hajnoczi , Paolo Bonzini , lcapitulino@redhat.com, Kevin Wolf , Nitesh Narayan Lal , Theodore Ts'o , Xiao Guangrong , cohuck@redhat.com, "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-xfs , linux-fsdevel , Igor Mammedov > > On Tue, May 07, 2019 at 08:37:01AM -0700, Dan Williams wrote: > > On Thu, Apr 25, 2019 at 10:03 PM Pankaj Gupta wrote: > > > > > > Dont support 'MAP_SYNC' with non-DAX files and DAX files > > > with asynchronous dax_device. Virtio pmem provides > > > asynchronous host page cache flush mechanism. We don't > > > support 'MAP_SYNC' with virtio pmem and xfs. > > > > > > Signed-off-by: Pankaj Gupta > > > --- > > > fs/xfs/xfs_file.c | 9 ++++++--- > > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > Darrick, does this look ok to take through the nvdimm tree? > > forgot about this, sorry. :/ > > > > > > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > > > index a7ceae90110e..f17652cca5ff 100644 > > > --- a/fs/xfs/xfs_file.c > > > +++ b/fs/xfs/xfs_file.c > > > @@ -1203,11 +1203,14 @@ xfs_file_mmap( > > > struct file *filp, > > > struct vm_area_struct *vma) > > > { > > > + struct dax_device *dax_dev; > > > + > > > + dax_dev = xfs_find_daxdev_for_inode(file_inode(filp)); > > > /* > > > - * We don't support synchronous mappings for non-DAX files. At > > > least > > > - * until someone comes with a sensible use case. > > > + * We don't support synchronous mappings for non-DAX files and > > > + * for DAX files if underneath dax_device is not synchronous. > > > */ > > > - if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC)) > > > + if (!daxdev_mapping_supported(vma, dax_dev)) > > > return -EOPNOTSUPP; > > LGTM, and I'm fine with it going through nvdimm. Nothing in > xfs-5.2-merge touches that function so it should be clean. > > Reviewed-by: Darrick J. Wong Thank you for the review. Pankaj > > --D > > > > > > > file_accessed(filp); > > > -- > > > 2.20.1 > > > > >