From: John Garry <john.g.garry@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>, zlang@redhat.com
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/7] generic/767: only test the hardware atomic write unit
Date: Mon, 4 Aug 2025 08:41:33 +0100 [thread overview]
Message-ID: <7afe34e3-7131-4f01-9a4d-0120f99f75c8@oracle.com> (raw)
In-Reply-To: <175381957973.3020742.7280346741094447176.stgit@frogsfrogsfrogs>
On 29/07/2025 21:09, Darrick J. Wong wrote:
> From: Darrick J. Wong<djwong@kernel.org>
>
> This test sets up scsi_debug so that we can test the fs and block layer
> code for hardware-accelerated atomic writes (and not just a software
> fallback). However, the userspace ABI for detecting atomic write
> geometry has changed since the start of development (to include said
> software fallback) so we must add some extra code to find the real
> hardware capabilities, and base the write sizes based on that.
>
> This fixes a test failure with 32k blocksizes because the advertised
> atomic_write_unit_max is 128M and fallocate quickly runs out of space.
>
> While we're at it fix a stupid variable usage bug in the loop.
>
> Cc:<fstests@vger.kernel.org> # v2025.07.13
> Fixes: fa8694c823d853 ("generic: various atomic write tests with hardware and scsi_debug")
> Signed-off-by: "Darrick J. Wong"<djwong@kernel.org>
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2025-08-04 7:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 20:08 [PATCHSET 1/3] fstests: fixes for atomic writes tests Darrick J. Wong
2025-07-29 20:08 ` [PATCH 2/7] generic/427: try to ensure there's some free space before we do the aio test Darrick J. Wong
2025-07-30 14:18 ` Christoph Hellwig
2025-08-12 18:54 ` Darrick J. Wong
2025-08-13 5:15 ` Christoph Hellwig
2025-08-13 6:14 ` Darrick J. Wong
2025-08-13 6:24 ` Christoph Hellwig
2025-08-14 22:16 ` Darrick J. Wong
2025-08-18 4:37 ` Christoph Hellwig
2025-07-29 20:09 ` [PATCH 3/7] generic/767: require fallocate support Darrick J. Wong
2025-07-30 14:19 ` Christoph Hellwig
2025-08-04 7:38 ` John Garry
2025-07-29 20:09 ` [PATCH 4/7] generic/767: only test the hardware atomic write unit Darrick J. Wong
2025-07-30 14:19 ` Christoph Hellwig
2025-08-04 7:41 ` John Garry [this message]
2025-07-29 20:09 ` [PATCH 5/7] generic/767: allow on any atomic writes filesystem Darrick J. Wong
2025-08-01 18:56 ` Zorro Lang
2025-08-04 7:50 ` John Garry
2025-07-29 20:09 ` [PATCH 6/7] xfs/838: actually force usage of the realtime device Darrick J. Wong
2025-07-30 14:19 ` Christoph Hellwig
2025-08-04 8:02 ` John Garry
2025-07-29 20:10 ` [PATCH 7/7] common: fix _require_xfs_io_command pwrite -A for various blocksizes Darrick J. Wong
2025-08-01 18:53 ` Zorro Lang
2025-08-27 18:04 ` Darrick J. Wong
2025-08-04 8:07 ` John Garry
2025-08-01 6:19 ` [PATCHSET 1/3] fstests: fixes for atomic writes tests Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7afe34e3-7131-4f01-9a4d-0120f99f75c8@oracle.com \
--to=john.g.garry@oracle.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).