From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfsprogs: remove the libxfs_* API redirections
Date: Tue, 26 May 2020 14:10:01 -0500 [thread overview]
Message-ID: <7c6a3379-a4fc-97e8-ab31-34aa7dfd5a76@sandeen.net> (raw)
In-Reply-To: <20200513140333.2479519-2-hch@lst.de>
On 5/13/20 9:03 AM, Christoph Hellwig wrote:
> For historical reasons xfsprogs tries to renamed xfs_* symbols used
> by tools (but not those used inside libxfs) to libxfs_. Remove this
> indirection to make it clear what function is being called, and to
> avoid having to keep the renaming header uptodate.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I merged the first patch (scrub prefix removal) but I want to give this
one a little more thought. I'd be happy to get rid of this but I want
to be certain that we stay robust and correct w.r.t. error sign problems
and until I feel like I have that all in my brain, I'd like to leave this
as is.
Thanks,
-Eric
next prev parent reply other threads:[~2020-05-26 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 14:03 [PATCH 1/2] scrub: remove xfs_ prefixes from various function Christoph Hellwig
2020-05-13 14:03 ` [PATCH 2/2] xfsprogs: remove the libxfs_* API redirections Christoph Hellwig
2020-05-26 19:10 ` Eric Sandeen [this message]
2020-05-13 15:27 ` [PATCH 1/2] scrub: remove xfs_ prefixes from various function Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c6a3379-a4fc-97e8-ab31-34aa7dfd5a76@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox