From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH 0/2] xfs: don't require a dirty log on snapshots
Date: Wed, 7 Mar 2018 17:31:30 -0600 [thread overview]
Message-ID: <83696ce6-4054-0e77-b4b8-e82a1a9fbbc3@redhat.com> (raw)
Today, freezing an xfs filesystem will add a dummy log entry
after it quiesces the filesystem, to trigger unlinked inode
recovery on the next mount. This kind of sucks for readonly
snapshots on readonly devices; one must then specify
"-o ro,norecovery" or mount will fail, because the log appears
dirty. This is very nonobvious.
I propose improving the situation by moving unlinked inode recovery
out of log replay; check for and process unlinked inodes on every mount,
regardless of log dirtiness. This way we can create snapshots with
clean logs.
There may be some devils in the details here but it passes a quick
sanity check, so let's see what reviewers think, and see what I've
overlooked...
Thanks,
-Eric
next reply other threads:[~2018-03-07 23:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 23:31 Eric Sandeen [this message]
2018-03-07 23:32 ` [PATCH 1/2] xfs: always check for and process unlinked inodes on mount Eric Sandeen
2018-03-08 0:41 ` Eric Sandeen
2018-03-15 12:17 ` Brian Foster
2018-03-15 12:19 ` Eric Sandeen
2018-03-15 12:41 ` Brian Foster
2018-03-07 23:33 ` [PATCH 2/2] xfs: don't dirty snapshot logs for unlinked inode recovery Eric Sandeen
2018-03-24 16:20 ` Darrick J. Wong
2018-03-26 12:46 ` Brian Foster
2018-03-27 21:17 ` Dave Chinner
2021-02-23 13:42 ` Gao Xiang
2021-02-23 14:40 ` Eric Sandeen
2021-02-23 15:03 ` Gao Xiang
2021-02-23 15:46 ` Eric Sandeen
2021-02-23 15:58 ` Gao Xiang
2021-02-23 16:25 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83696ce6-4054-0e77-b4b8-e82a1a9fbbc3@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).