From: Nathan Scott <nscott@aconex.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] mkfs: add discard support
Date: Wed, 7 Oct 2009 06:24:33 +1100 (EST) [thread overview]
Message-ID: <837780486.21741254857073773.JavaMail.root@mail-au.aconex.com> (raw)
In-Reply-To: <1235789111.21721254856913943.JavaMail.root@mail-au.aconex.com>
----- "Christoph Hellwig" <hch@infradead.org> wrote:
> Index: xfsprogs-dev/mkfs/xfs_mkfs.c
> ===================================================================
> --- xfsprogs-dev.orig/mkfs/xfs_mkfs.c 2009-10-06 18:02:34.000000000
> +0000
> +++ xfsprogs-dev/mkfs/xfs_mkfs.c 2009-10-06 18:03:55.000000000 +0000
> @@ -605,6 +605,29 @@ done:
> free(buf);
> }
>
> +#ifdef __linux__
> +
> +#ifndef BLKDISCARD
> +#define BLKDISCARD _IO(0x12,119)
> +#endif
It might be a bit cleaner to add this in with the existing platform-
specific code in libxfs/linux.c (or perhaps include/platform_defs.h)
with wrappers for the other platforms, rather than putting it directly
in mkfs like this? repair may want to use this someday too, I guess.
cheers.
--
Nathan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2009-10-06 19:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1235789111.21721254856913943.JavaMail.root@mail-au.aconex.com>
2009-10-06 19:24 ` Nathan Scott [this message]
2009-10-06 19:26 ` [PATCH] mkfs: add discard support Christoph Hellwig
2009-10-07 1:18 ` Christoph Hellwig
2009-10-07 1:20 ` Nathan Scott
2009-10-07 3:55 ` Eric Sandeen
2009-11-12 16:04 ` Christoph Hellwig
2009-10-06 18:47 Christoph Hellwig
2009-10-07 4:42 ` Dave Chinner
2009-10-07 6:05 ` Michael Monnerie
2009-10-07 14:11 ` Christoph Hellwig
2009-10-07 20:24 ` Andi Kleen
2009-10-09 2:30 ` Dave Chinner
2009-10-10 4:22 ` Andi Kleen
2009-10-10 16:24 ` Christoph Hellwig
2009-10-12 1:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837780486.21741254857073773.JavaMail.root@mail-au.aconex.com \
--to=nscott@aconex.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox