From: John Garry <john.g.garry@oracle.com>
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Christoph Hellwig <hch@lst.de>
Cc: brauner@kernel.org, djwong@kernel.org,
linux-fsdevel@vger.kernel.org, dchinner@redhat.com,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
ojaswin@linux.ibm.com, martin.petersen@oracle.com, tytso@mit.edu,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] iomap: rework IOMAP atomic flags
Date: Wed, 26 Mar 2025 15:50:42 +0000 [thread overview]
Message-ID: <8377df78-42fe-486c-acd9-3bcfbbc43cf3@oracle.com> (raw)
In-Reply-To: <87bjtrsw2d.fsf@gmail.com>
>>> So, I guess we can shift IOMAP_F_SIZE_CHANGED and IOMAP_F_STALE by
>>> 1 bit. So it will all look like..
>>
>> Let's create some more space to avoid this for the next round, e.g.
>
> Sure, that make sense.
>
>> count the core set flags from 31 down, and limit IOMAP_F_PRIVATE to a
>> single flag, which is how it is used.
>
> flags in struct iomap is of type u16. So will make core iomap flags
> starting from bit 15, moving downwards.
>
> Here is a diff of what I think you meant - let me know if this diff
> looks good to you?
This is still outstanding, and it would be nice to fix this ASAP.
How about we go to 32b and change IOMAP_F_PRIVATE for v6.16, while just
fix as suggested originally (by renumbering) for v6.15?
next prev parent reply other threads:[~2025-03-26 15:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 12:02 [PATCH 0/3] further iomap large atomic writes changes John Garry
2025-03-20 12:02 ` [PATCH 1/3] iomap: inline iomap_dio_bio_opflags() John Garry
2025-03-20 12:02 ` [PATCH 2/3] iomap: comment on atomic write checks in iomap_dio_bio_iter() John Garry
2025-03-20 14:09 ` Christoph Hellwig
2025-03-20 19:32 ` Ritesh Harjani
2025-03-20 12:02 ` [PATCH 3/3] iomap: rework IOMAP atomic flags John Garry
2025-03-20 14:10 ` Christoph Hellwig
2025-03-20 19:29 ` Ritesh Harjani
2025-03-22 19:47 ` Ritesh Harjani
2025-03-23 6:38 ` Christoph Hellwig
2025-03-23 13:07 ` John Garry
2025-03-23 13:42 ` Ritesh Harjani
2025-03-26 15:50 ` John Garry [this message]
2025-03-27 10:46 ` Christoph Hellwig
2025-03-20 14:16 ` [PATCH 0/3] further iomap large atomic writes changes Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8377df78-42fe-486c-acd9-3bcfbbc43cf3@oracle.com \
--to=john.g.garry@oracle.com \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox