From: chandan <chandan@linux.vnet.ibm.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
sekharan@linux.vnet.ibm.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: generic/255: Execute only if blocksize <= 4096
Date: Wed, 28 Aug 2013 13:44:09 +0530 [thread overview]
Message-ID: <8507420.Xnl9a5Gq1S@localhost.localdomain> (raw)
In-Reply-To: <521CD7FC.1080706@sandeen.net>
On Tuesday, August 27, 2013 11:46:52 AM Eric Sandeen wrote:
> On 8/27/13 7:16 AM, chandan wrote:
> > On Monday, August 26, 2013 09:29:31 AM Eric Sandeen wrote:
> >>
> >> Just as a sanity check, does it also fail on xfs for 64k block sizes on ppc64?
> >>
> >
> > Yes, it does fail as shown below:
> >
>
> (removing linux-btrfs for now):
>
> Hohum, I get failures on 2k and even 4k blocksize xfs (and ext4) on ppc64 as well.
> (this was on a 3.10 kernel)
>
> Have you seen this?
>
> I guess I'm a little reluctant to restrict the test to <=4k until we understand
> what all the issues are and at least see it passing on the smaller block
> sizes... do they work for you?
>
> -Eric
>
Eric,
I have posted a patch that fixes _test_generic_punch() to obtain the correct
block size. With that patch applied, the code works for 4k blocksize for
both xfs and ext4.
Even the with the above mentioned fix applied, the code doesn't work with
block sizes != 4k. The extent ranges in 255.out were obtained for 4k block
sizes and hence they don't work for other block sizes. I will repost the
patch to restrict execution of generic/255 only when the block size is 4k.
- chandan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-08-28 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-25 15:06 [PATCH] xfstests: generic/255: Execute only if blocksize <= 4096 chandan
2013-08-25 16:54 ` Eric Sandeen
2013-08-26 5:38 ` chandan
2013-08-26 14:29 ` Eric Sandeen
2013-08-27 12:16 ` chandan
2013-08-27 16:46 ` Eric Sandeen
2013-08-28 8:14 ` chandan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8507420.Xnl9a5Gq1S@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=sekharan@linux.vnet.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox