Re: [PATCH v5 77/78] irqdomain: Convert to XArray

[Marc Zyngier <marc.zyngier@arm.com>]

On Fri, 15 Dec 2017 22:04:49 +0000,
Matthew Wilcox wrote:
> 
> From: Matthew Wilcox <mawilcox@microsoft.com>
> 
> In a non-critical path, irqdomain wants to know how many entries are
> stored in the xarray, so add xa_count().  This is a pretty straightforward
> conversion; mostly just removing now-redundant locking.  The only thing
> of note is just how much simpler irq_domain_fix_revmap() becomes.
> 
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
>  include/linux/irqdomain.h | 10 ++++------
>  include/linux/xarray.h    |  1 +
>  kernel/irq/irqdomain.c    | 39 ++++++++++-----------------------------
>  lib/xarray.c              | 25 +++++++++++++++++++++++++
>  4 files changed, 40 insertions(+), 35 deletions(-)

I certainly welcome the simplification this provides.

As for xa_count(), I'm trying to convince myself that the code under
CONFIG_IRQ_DOMAIN_DEBUG is now completely superseded by
CONFIG_GENERIC_IRQ_DEBUGFS, and that there would be more value in
getting rid of it rather than keeping it on life support.

Until then, the 1:1 replacement is good enough.

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.