From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37070 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbdLPKvM (ORCPT ); Sat, 16 Dec 2017 05:51:12 -0500 Date: Sat, 16 Dec 2017 10:51:05 +0000 Message-ID: <867etnvtd2.wl-marc.zyngier@arm.com> From: Marc Zyngier Subject: Re: [PATCH v5 77/78] irqdomain: Convert to XArray In-Reply-To: <20171215220450.7899-78-willy@infradead.org> References: <20171215220450.7899-1-willy@infradead.org> <20171215220450.7899-78-willy@infradead.org> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, Matthew Wilcox , Ross Zwisler , David Howells , Shaohua Li , Jens Axboe , Rehas Sachdeva , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-usb@vger.kernel.org, linux-raid@vger.kernel.org On Fri, 15 Dec 2017 22:04:49 +0000, Matthew Wilcox wrote: > > From: Matthew Wilcox > > In a non-critical path, irqdomain wants to know how many entries are > stored in the xarray, so add xa_count(). This is a pretty straightforward > conversion; mostly just removing now-redundant locking. The only thing > of note is just how much simpler irq_domain_fix_revmap() becomes. > > Signed-off-by: Matthew Wilcox > --- > include/linux/irqdomain.h | 10 ++++------ > include/linux/xarray.h | 1 + > kernel/irq/irqdomain.c | 39 ++++++++++----------------------------- > lib/xarray.c | 25 +++++++++++++++++++++++++ > 4 files changed, 40 insertions(+), 35 deletions(-) I certainly welcome the simplification this provides. As for xa_count(), I'm trying to convince myself that the code under CONFIG_IRQ_DOMAIN_DEBUG is now completely superseded by CONFIG_GENERIC_IRQ_DEBUGFS, and that there would be more value in getting rid of it rather than keeping it on life support. Until then, the 1:1 replacement is good enough. Acked-by: Marc Zyngier M.