Re: [PATCH xfsprogs] configure: additionally get icu-uc from pkg-config

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

Alyssa Ross <hi@alyssa.is> writes:

> "Darrick J. Wong" <djwong@kernel.org> writes:
>
>> On Wed, Feb 12, 2025 at 09:16:49AM +0100, Alyssa Ross wrote:
>>> This fixes the following build error with icu 76, also seen by
>>> Fedora[1]:
>>> 
>>> 	/nix/store/9g4gsby96w4cx1i338kplaap0x37apdf-binutils-2.43.1/bin/ld: unicrash.o: undefined reference to symbol 'uiter_setString_76'
>>> 	/nix/store/9g4gsby96w4cx1i338kplaap0x37apdf-binutils-2.43.1/bin/ld: /nix/store/jbnm36wq89c7iws6xx6xvv75h0drv48x-icu4c-76.1/lib/libicuuc.so.76: error adding symbols: DSO missing from command line
>>> 	collect2: error: ld returned 1 exit status
>>> 	make[2]: *** [../include/buildrules:65: xfs_scrub] Error 1
>>> 	make[1]: *** [include/buildrules:35: scrub] Error 2
>>> 
>>> Link: https://src.fedoraproject.org/rpms/xfsprogs/c/624b0fdf7b2a31c1a34787b04e791eee47c97340 [1]
>>> Signed-off-by: Alyssa Ross <hi@alyssa.is>
>>
>> Interesting that this pulls in libicuuc just fine without including
>> icu-uc.pc, at least on Debian 12:
>>
>> $ grep LIBICU_LIBS build-x86_64/
>> build-x86_64/include/builddefs:222:LIBICU_LIBS = -licui18n -licuuc -licudata
>>
>> Debian sid has the same icu 76 and (AFAICT) it still pulls in the
>> dependency:
>>
>> Name: icu-i18n
>> Requires: icu-uc
>
> I don't know too much about Debian, so I might be doing something wrong,
> but when I looked in a fresh Debian Sid container I see a libicu-dev
> package that's still on 72.1-6, a libicu76 package, but no libicu76
> package.  I'm not sure there's currently a package that installs the
> icu-i18n.pc from ICU 76?

Here I meant "no libicu75-dev package".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]