From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Catherine Hoang <catherine.hoang@oracle.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Cc: djwong@kernel.org, john.g.garry@oracle.com
Subject: Re: [PATCH v2 1/6] generic/765: fix a few issues
Date: Tue, 20 May 2025 07:40:53 +0530 [thread overview]
Message-ID: <875xhwvxoy.fsf@gmail.com> (raw)
In-Reply-To: <20250520013400.36830-2-catherine.hoang@oracle.com>
Catherine Hoang <catherine.hoang@oracle.com> writes:
> From: "Darrick J. Wong" <djwong@kernel.org>
>
> Fix a few bugs in the single block atomic writes test, such as not requiring
> directio, using the page size for the ext4 max bsize, and making sure we check
> the max atomic write size.
>
> Cc: ritesh.list@gmail.com
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
> common/rc | 2 +-
> tests/generic/765 | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Thanks for fixing this for 64k pagesize.
Looks good to me. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>
> diff --git a/common/rc b/common/rc
> index 657772e7..0ac90d3e 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2989,7 +2989,7 @@ _require_xfs_io_command()
> fi
> if [ "$param" == "-A" ]; then
> opts+=" -d"
> - pwrite_opts+="-D -V 1 -b 4k"
> + pwrite_opts+="-V 1 -b 4k"
> fi
> testio=`$XFS_IO_PROG -f $opts -c \
> "pwrite $pwrite_opts $param 0 4k" $testfile 2>&1`
> diff --git a/tests/generic/765 b/tests/generic/765
> index 9bab3b8a..8695a306 100755
> --- a/tests/generic/765
> +++ b/tests/generic/765
> @@ -28,7 +28,7 @@ get_supported_bsize()
> ;;
> "ext4")
> min_bsize=1024
> - max_bsize=4096
> + max_bsize=$(_get_page_size)
> ;;
> *)
> _notrun "$FSTYP does not support atomic writes"
> @@ -73,7 +73,7 @@ test_atomic_writes()
> # Check that atomic min/max = FS block size
> test $file_min_write -eq $bsize || \
> echo "atomic write min $file_min_write, should be fs block size $bsize"
> - test $file_min_write -eq $bsize || \
> + test $file_max_write -eq $bsize || \
> echo "atomic write max $file_max_write, should be fs block size $bsize"
> test $file_max_segments -eq 1 || \
> echo "atomic write max segments $file_max_segments, should be 1"
> --
> 2.34.1
next prev parent reply other threads:[~2025-05-20 2:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 1:33 [PATCH v2 0/6] atomic writes tests Catherine Hoang
2025-05-20 1:33 ` [PATCH v2 1/6] generic/765: fix a few issues Catherine Hoang
2025-05-20 2:10 ` Ritesh Harjani [this message]
2025-05-22 10:14 ` Ojaswin Mujoo
2025-05-20 1:33 ` [PATCH v2 2/6] generic/765: adjust various things Catherine Hoang
2025-05-22 10:14 ` Ojaswin Mujoo
2025-05-20 1:33 ` [PATCH v2 3/6] generic/765: move common atomic write code to a library file Catherine Hoang
2025-05-22 10:26 ` Ojaswin Mujoo
2025-05-20 1:33 ` [PATCH v2 4/6] common/atomicwrites: adjust a few more things Catherine Hoang
2025-05-22 10:37 ` Ojaswin Mujoo
2025-05-20 1:33 ` [PATCH v2 5/6] common/atomicwrites: fix _require_scratch_write_atomic Catherine Hoang
2025-05-20 2:14 ` Ritesh Harjani
2025-05-20 1:34 ` [PATCH v2 6/6] generic: various atomic write tests with scsi_debug Catherine Hoang
2025-05-20 12:05 ` Ritesh Harjani
2025-05-21 2:30 ` Darrick J. Wong
2025-05-22 10:33 ` Ojaswin Mujoo
2025-05-28 22:00 ` Darrick J. Wong
2025-05-21 4:43 ` Ritesh Harjani
2025-05-22 10:53 ` Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xhwvxoy.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=catherine.hoang@oracle.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).