public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: fix log filtering in 223's testcase
@ 2010-03-09 17:27 Dmitry Monakhov
  2010-03-09 17:58 ` Eric Sandeen
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Monakhov @ 2010-03-09 17:27 UTC (permalink / raw)
  To: xfs-oss; +Cc: Christoph Hellwig, Eric Sandeen


Msg filter was missed in one place, so test failed if
$SCRATCH_MNT is different than /mnt/scratch.diff 

Signed-off-by: Dimitry Monakhov <dmonakhov@openvz.org>
---
 223     |    3 ++-
 223.out |   10 +++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/223 b/223
index 5c95f7d..7af026c 100755
--- a/223
+++ b/223
@@ -86,7 +86,8 @@ for SUNIT_K in 8 16 32 64 128; do
 
 	echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
 	xfs_io -F -f -c "falloc 0 1g" $SCRATCH_MNT/file-1g-falloc &>> $seq.full
-	src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS
+	src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
+	    | _filter_scratch
 
 	rm -f $SCRATCH_MNT/file-1g-falloc | _filter_scratch
 
diff --git a/223.out b/223.out
index c9588ef..2fb3122 100644
--- a/223.out
+++ b/223.out
@@ -46,7 +46,7 @@ SCRATCH_MNT/file-3-2097152-write: well-aligned
 SCRATCH_MNT/file-4-2097152-falloc: well-aligned
 SCRATCH_MNT/file-4-2097152-write: well-aligned
 === Testing size 1g falloc on 8k stripe ===
-/mnt/scratch/file-1g-falloc: well-aligned
+SCRATCH_MNT/file-1g-falloc: well-aligned
 === Testing size 1073745920 falloc on 8k stripe ===
 SCRATCH_MNT/file-1073745920-falloc: well-aligned
 === mkfs with su 4 blocks x 4 ===
@@ -96,7 +96,7 @@ SCRATCH_MNT/file-3-4194304-write: well-aligned
 SCRATCH_MNT/file-4-4194304-falloc: well-aligned
 SCRATCH_MNT/file-4-4194304-write: well-aligned
 === Testing size 1g falloc on 16k stripe ===
-/mnt/scratch/file-1g-falloc: well-aligned
+SCRATCH_MNT/file-1g-falloc: well-aligned
 === Testing size 1073745920 falloc on 16k stripe ===
 SCRATCH_MNT/file-1073745920-falloc: well-aligned
 === mkfs with su 8 blocks x 4 ===
@@ -146,7 +146,7 @@ SCRATCH_MNT/file-3-8388608-write: well-aligned
 SCRATCH_MNT/file-4-8388608-falloc: well-aligned
 SCRATCH_MNT/file-4-8388608-write: well-aligned
 === Testing size 1g falloc on 32k stripe ===
-/mnt/scratch/file-1g-falloc: well-aligned
+SCRATCH_MNT/file-1g-falloc: well-aligned
 === Testing size 1073745920 falloc on 32k stripe ===
 SCRATCH_MNT/file-1073745920-falloc: well-aligned
 === mkfs with su 16 blocks x 4 ===
@@ -196,7 +196,7 @@ SCRATCH_MNT/file-3-16777216-write: well-aligned
 SCRATCH_MNT/file-4-16777216-falloc: well-aligned
 SCRATCH_MNT/file-4-16777216-write: well-aligned
 === Testing size 1g falloc on 64k stripe ===
-/mnt/scratch/file-1g-falloc: well-aligned
+SCRATCH_MNT/file-1g-falloc: well-aligned
 === Testing size 1073745920 falloc on 64k stripe ===
 SCRATCH_MNT/file-1073745920-falloc: well-aligned
 === mkfs with su 32 blocks x 4 ===
@@ -246,6 +246,6 @@ SCRATCH_MNT/file-3-33554432-write: well-aligned
 SCRATCH_MNT/file-4-33554432-falloc: well-aligned
 SCRATCH_MNT/file-4-33554432-write: well-aligned
 === Testing size 1g falloc on 128k stripe ===
-/mnt/scratch/file-1g-falloc: well-aligned
+SCRATCH_MNT/file-1g-falloc: well-aligned
 === Testing size 1073745920 falloc on 128k stripe ===
 SCRATCH_MNT/file-1073745920-falloc: well-aligned
-- 
1.6.6

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: fix log filtering in 223's testcase
  2010-03-09 17:27 [PATCH] xfstests: fix log filtering in 223's testcase Dmitry Monakhov
@ 2010-03-09 17:58 ` Eric Sandeen
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2010-03-09 17:58 UTC (permalink / raw)
  To: Dmitry Monakhov; +Cc: Christoph Hellwig, Eric Sandeen, xfs-oss

Dmitry Monakhov wrote:
> Msg filter was missed in one place, so test failed if
> $SCRATCH_MNT is different than /mnt/scratch.diff 
> 
> Signed-off-by: Dimitry Monakhov <dmonakhov@openvz.org>

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

Whoops, yep!  Sorry.

I'll commit this shortly.

Thanks,
-Eric

> ---
>  223     |    3 ++-
>  223.out |   10 +++++-----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/223 b/223
> index 5c95f7d..7af026c 100755
> --- a/223
> +++ b/223
> @@ -86,7 +86,8 @@ for SUNIT_K in 8 16 32 64 128; do
>  
>  	echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
>  	xfs_io -F -f -c "falloc 0 1g" $SCRATCH_MNT/file-1g-falloc &>> $seq.full
> -	src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS
> +	src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
> +	    | _filter_scratch
>  
>  	rm -f $SCRATCH_MNT/file-1g-falloc | _filter_scratch
>  
> diff --git a/223.out b/223.out
> index c9588ef..2fb3122 100644
> --- a/223.out
> +++ b/223.out
> @@ -46,7 +46,7 @@ SCRATCH_MNT/file-3-2097152-write: well-aligned
>  SCRATCH_MNT/file-4-2097152-falloc: well-aligned
>  SCRATCH_MNT/file-4-2097152-write: well-aligned
>  === Testing size 1g falloc on 8k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 8k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 4 blocks x 4 ===
> @@ -96,7 +96,7 @@ SCRATCH_MNT/file-3-4194304-write: well-aligned
>  SCRATCH_MNT/file-4-4194304-falloc: well-aligned
>  SCRATCH_MNT/file-4-4194304-write: well-aligned
>  === Testing size 1g falloc on 16k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 16k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 8 blocks x 4 ===
> @@ -146,7 +146,7 @@ SCRATCH_MNT/file-3-8388608-write: well-aligned
>  SCRATCH_MNT/file-4-8388608-falloc: well-aligned
>  SCRATCH_MNT/file-4-8388608-write: well-aligned
>  === Testing size 1g falloc on 32k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 32k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 16 blocks x 4 ===
> @@ -196,7 +196,7 @@ SCRATCH_MNT/file-3-16777216-write: well-aligned
>  SCRATCH_MNT/file-4-16777216-falloc: well-aligned
>  SCRATCH_MNT/file-4-16777216-write: well-aligned
>  === Testing size 1g falloc on 64k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 64k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned
>  === mkfs with su 32 blocks x 4 ===
> @@ -246,6 +246,6 @@ SCRATCH_MNT/file-3-33554432-write: well-aligned
>  SCRATCH_MNT/file-4-33554432-falloc: well-aligned
>  SCRATCH_MNT/file-4-33554432-write: well-aligned
>  === Testing size 1g falloc on 128k stripe ===
> -/mnt/scratch/file-1g-falloc: well-aligned
> +SCRATCH_MNT/file-1g-falloc: well-aligned
>  === Testing size 1073745920 falloc on 128k stripe ===
>  SCRATCH_MNT/file-1073745920-falloc: well-aligned

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-09 17:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-09 17:27 [PATCH] xfstests: fix log filtering in 223's testcase Dmitry Monakhov
2010-03-09 17:58 ` Eric Sandeen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox