linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Creating written extents beyond EOF
@ 2022-09-01 13:25 Chandan Babu R
  2022-09-02 21:55 ` Dave Chinner
  0 siblings, 1 reply; 3+ messages in thread
From: Chandan Babu R @ 2022-09-01 13:25 UTC (permalink / raw)
  To: Dave Chinner; +Cc: linux-xfs

Hi Dave,

7684e2c4384d5d1f884b01ab8bff2369e4db0bff
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7684e2c4384d5d1f884b01ab8bff2369e4db0bff)
is one of the commits that needs to be backported to 5.4.y stable kernel.

The commit message mentions that we could have written extents beyond EOF. I
am unable to come up with a sequence of commands that could create such
extents.

Can you please explain how a user could create a file having written extents
beyond EOF?

-- 
chandan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Creating written extents beyond EOF
  2022-09-01 13:25 Creating written extents beyond EOF Chandan Babu R
@ 2022-09-02 21:55 ` Dave Chinner
  2022-09-06  6:55   ` Chandan Babu R
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2022-09-02 21:55 UTC (permalink / raw)
  To: Chandan Babu R; +Cc: linux-xfs

On Thu, Sep 01, 2022 at 06:55:31PM +0530, Chandan Babu R wrote:
> Hi Dave,
> 
> 7684e2c4384d5d1f884b01ab8bff2369e4db0bff
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7684e2c4384d5d1f884b01ab8bff2369e4db0bff)
> is one of the commits that needs to be backported to 5.4.y stable kernel.
> 
> The commit message mentions that we could have written extents beyond EOF. I
> am unable to come up with a sequence of commands that could create such
> extents.
> 
> Can you please explain how a user could create a file having written extents
> beyond EOF?

That bug fix was committed in v5.5. We didn't convert delalloc to
use unwritten extents until v5.8 via commit a5949d3faedf.

-Dave.
-- 
Dave Chinner
david@fromorbit.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Creating written extents beyond EOF
  2022-09-02 21:55 ` Dave Chinner
@ 2022-09-06  6:55   ` Chandan Babu R
  0 siblings, 0 replies; 3+ messages in thread
From: Chandan Babu R @ 2022-09-06  6:55 UTC (permalink / raw)
  To: Dave Chinner; +Cc: linux-xfs

On Sat, Sep 03, 2022 at 07:55:16 AM +1000, Dave Chinner wrote:
> On Thu, Sep 01, 2022 at 06:55:31PM +0530, Chandan Babu R wrote:
>> Hi Dave,
>> 
>> 7684e2c4384d5d1f884b01ab8bff2369e4db0bff
>> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7684e2c4384d5d1f884b01ab8bff2369e4db0bff)
>> is one of the commits that needs to be backported to 5.4.y stable kernel.
>> 
>> The commit message mentions that we could have written extents beyond EOF. I
>> am unable to come up with a sequence of commands that could create such
>> extents.
>> 
>> Can you please explain how a user could create a file having written extents
>> beyond EOF?
>
> That bug fix was committed in v5.5. We didn't convert delalloc to
> use unwritten extents until v5.8 via commit a5949d3faedf.
>

Ok. Thanks for clarifying my doubt. I can now recreate the bug on my test
machine when running v5.4 LTS kernel.

-- 
chandan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-06  6:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-01 13:25 Creating written extents beyond EOF Chandan Babu R
2022-09-02 21:55 ` Dave Chinner
2022-09-06  6:55   ` Chandan Babu R

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).