Re: [PATCH 1/8] xfs: change the type of ic_datap

Brian Foster
2021-06-17T16:23:02Z

On Wed, Jun 16, 2021 at 06:32:05PM +0200, Christoph Hellwig wrote:
> Turn ic_datap from a char into a void pointer given that it points
> to arbitrary data.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

> fs/xfs/xfs_log.c | 2 +-
> fs/xfs/xfs_log_priv.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index e921b554b68367..8999c78f3ac6d9 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -3613,7 +3613,7 @@ xlog_verify_iclog(
> if (field_offset & 0x1ff) {
> clientid = ophead->oh_clientid;
> } else {
> - idx = BTOBBT((char *)&ophead->oh_clientid - iclog->ic_datap);
> + idx = BTOBBT((void *)&ophead->oh_clientid - iclog->ic_datap);
> if (idx >= (XLOG_HEADER_CYCLE_SIZE / BBSIZE)) {
> j = idx / (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> k = idx % (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index e4e421a7033558..96dbe713954f7e 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -185,7 +185,7 @@ typedef struct xlog_in_core {
> u32 ic_offset;
> enum xlog_iclog_state ic_state;
> unsigned int ic_flags;
> - char *ic_datap; /* pointer to iclog data */
> + void *ic_datap; /* pointer to iclog data */
>
> /* Callback structures need their own cacheline */
> spinlock_t ic_callback_lock ____cacheline_aligned_in_smp;
> --
> 2.30.2
>