From: "Benjamin Coddington" <bcodding@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, linux-xfs@vger.kernel.org
Subject: Re: SEEK_HOLE second hole problem
Date: Fri, 14 Oct 2016 06:24:39 -0400 [thread overview]
Message-ID: <879EDADE-C646-4173-A3FD-253D11470799@redhat.com> (raw)
In-Reply-To: <20161012205405.GE27872@dastard>
On 12 Oct 2016, at 16:54, Dave Chinner wrote:
>> Like me, generic/285 seems to have gotten this wrong too, but
>
> The test isn't wrong - it's just a demonstration of the fact we
> can't easily cater for every different allocation strategy that
> filesystems and storage uses to optimise IO patterns and pervent
> fragmentation.
Regarding generic/285 -- I'd like to have it work for NFS. Maybe using
SEEK_DATA to discover an appropriate allocation size for filesystems
exported by NFS could work by writing to increasing offsets until a seek for
data from the beginning of the file reveals the second allocation.
That seems to work for xfs, ext4, btrfs, and tmpfs exports. I'll send a
patch with that to fstests.
Ben
prev parent reply other threads:[~2016-10-14 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 16:15 SEEK_HOLE second hole problem Benjamin Coddington
2016-10-12 17:06 ` Eric Sandeen
2016-10-12 18:40 ` Benjamin Coddington
2016-10-12 20:54 ` Dave Chinner
2016-10-13 0:50 ` Benjamin Coddington
2016-10-14 10:24 ` Benjamin Coddington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=879EDADE-C646-4173-A3FD-253D11470799@redhat.com \
--to=bcodding@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).