From: Chandan Babu R <chandan.babu@oracle.com>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v27 15/15] xfs: add leaf to node error tag
Date: Wed, 16 Feb 2022 20:30:17 +0530 [thread overview]
Message-ID: <87a6eqj1q6.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20220216013713.1191082-16-allison.henderson@oracle.com>
On 16 Feb 2022 at 07:07, Allison Henderson wrote:
> Add an error tag on xfs_attr3_leaf_to_node to test log attribute
> recovery and replay.
>
Looks good.
Reviewed-by: Chandan Babu R <chandan.babu@oracle.com>
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> fs/xfs/libxfs/xfs_attr_leaf.c | 6 ++++++
> fs/xfs/libxfs/xfs_errortag.h | 4 +++-
> fs/xfs/xfs_error.c | 3 +++
> 3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> index 74b76b09509f..e90bfd9d7551 100644
> --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> @@ -28,6 +28,7 @@
> #include "xfs_dir2.h"
> #include "xfs_log.h"
> #include "xfs_ag.h"
> +#include "xfs_errortag.h"
>
>
> /*
> @@ -1189,6 +1190,11 @@ xfs_attr3_leaf_to_node(
>
> trace_xfs_attr_leaf_to_node(args);
>
> + if (XFS_TEST_ERROR(false, mp, XFS_ERRTAG_ATTR_LEAF_TO_NODE)) {
> + error = -EIO;
> + goto out;
> + }
> +
> error = xfs_da_grow_inode(args, &blkno);
> if (error)
> goto out;
> diff --git a/fs/xfs/libxfs/xfs_errortag.h b/fs/xfs/libxfs/xfs_errortag.h
> index 6d06a502bbdf..5362908164b0 100644
> --- a/fs/xfs/libxfs/xfs_errortag.h
> +++ b/fs/xfs/libxfs/xfs_errortag.h
> @@ -61,7 +61,8 @@
> #define XFS_ERRTAG_AG_RESV_FAIL 38
> #define XFS_ERRTAG_LARP 39
> #define XFS_ERRTAG_DA_LEAF_SPLIT 40
> -#define XFS_ERRTAG_MAX 41
> +#define XFS_ERRTAG_ATTR_LEAF_TO_NODE 41
> +#define XFS_ERRTAG_MAX 42
>
> /*
> * Random factors for above tags, 1 means always, 2 means 1/2 time, etc.
> @@ -107,5 +108,6 @@
> #define XFS_RANDOM_AG_RESV_FAIL 1
> #define XFS_RANDOM_LARP 1
> #define XFS_RANDOM_DA_LEAF_SPLIT 1
> +#define XFS_RANDOM_ATTR_LEAF_TO_NODE 1
>
> #endif /* __XFS_ERRORTAG_H_ */
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index 2aa5d4d2b30a..296faa41d81d 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -59,6 +59,7 @@ static unsigned int xfs_errortag_random_default[] = {
> XFS_RANDOM_AG_RESV_FAIL,
> XFS_RANDOM_LARP,
> XFS_RANDOM_DA_LEAF_SPLIT,
> + XFS_RANDOM_ATTR_LEAF_TO_NODE,
> };
>
> struct xfs_errortag_attr {
> @@ -174,6 +175,7 @@ XFS_ERRORTAG_ATTR_RW(bmap_alloc_minlen_extent, XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTE
> XFS_ERRORTAG_ATTR_RW(ag_resv_fail, XFS_ERRTAG_AG_RESV_FAIL);
> XFS_ERRORTAG_ATTR_RW(larp, XFS_ERRTAG_LARP);
> XFS_ERRORTAG_ATTR_RW(da_leaf_split, XFS_ERRTAG_DA_LEAF_SPLIT);
> +XFS_ERRORTAG_ATTR_RW(attr_leaf_to_node, XFS_ERRTAG_ATTR_LEAF_TO_NODE);
>
> static struct attribute *xfs_errortag_attrs[] = {
> XFS_ERRORTAG_ATTR_LIST(noerror),
> @@ -217,6 +219,7 @@ static struct attribute *xfs_errortag_attrs[] = {
> XFS_ERRORTAG_ATTR_LIST(ag_resv_fail),
> XFS_ERRORTAG_ATTR_LIST(larp),
> XFS_ERRORTAG_ATTR_LIST(da_leaf_split),
> + XFS_ERRORTAG_ATTR_LIST(attr_leaf_to_node),
> NULL,
> };
> ATTRIBUTE_GROUPS(xfs_errortag);
--
chandan
prev parent reply other threads:[~2022-02-16 15:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 1:36 [PATCH v27 00/15] xfs: Log Attribute Replay Allison Henderson
2022-02-16 1:36 ` [PATCH v27 01/15] xfs: Fix double unlock in defer capture code Allison Henderson
2022-02-16 14:47 ` Chandan Babu R
2022-02-16 1:37 ` [PATCH v27 02/15] xfs: don't commit the first deferred transaction without intents Allison Henderson
2022-02-16 2:27 ` Darrick J. Wong
2022-02-16 14:47 ` Chandan Babu R
2022-02-16 1:37 ` [PATCH v27 03/15] xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process Allison Henderson
2022-02-16 1:37 ` [PATCH v27 04/15] xfs: Set up infrastructure for log attribute replay Allison Henderson
2022-02-16 1:37 ` [PATCH v27 05/15] xfs: Implement attr logging and replay Allison Henderson
2022-02-16 1:37 ` [PATCH v27 06/15] xfs: Skip flip flags for delayed attrs Allison Henderson
2022-02-16 1:37 ` [PATCH v27 07/15] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2022-02-16 1:37 ` [PATCH v27 08/15] xfs: Remove unused xfs_attr_*_args Allison Henderson
2022-02-16 1:37 ` [PATCH v27 09/15] xfs: Add log attribute error tag Allison Henderson
2022-02-16 1:37 ` [PATCH v27 10/15] xfs: Add larp debug option Allison Henderson
2022-02-16 1:37 ` [PATCH v27 11/15] xfs: Merge xfs_delattr_context into xfs_attr_item Allison Henderson
2022-02-16 1:37 ` [PATCH v27 12/15] xfs: Add helper function xfs_attr_leaf_addname Allison Henderson
2022-02-16 1:37 ` [PATCH v27 13/15] xfs: Add helper function xfs_init_attr_trans Allison Henderson
2022-02-16 2:30 ` Darrick J. Wong
2022-02-16 14:48 ` Chandan Babu R
2022-02-16 1:37 ` [PATCH v27 14/15] xfs: add leaf split error tag Allison Henderson
2022-02-16 14:59 ` Chandan Babu R
2022-02-16 1:37 ` [PATCH v27 15/15] xfs: add leaf to node " Allison Henderson
2022-02-16 15:00 ` Chandan Babu R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6eqj1q6.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandan.babu@oracle.com \
--cc=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox