From: Ferenc Wagner <wferi@niif.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Peter Staubach <staubach@redhat.com>,
Miklos Szeredi <mszeredi@suse.cz>, Ray Lee <ray-lk@madrabbit.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mmap vs mtime in 2.6.26 and up
Date: Wed, 22 Jul 2009 19:52:09 +0200 [thread overview]
Message-ID: <87ab2w8v1y.fsf@tac.ki.iif.hu> (raw)
In-Reply-To: <20090518114305.GA6303@infradead.org> (Christoph Hellwig's message of "Mon, 18 May 2009 07:43:05 -0400")
Christoph Hellwig <hch@infradead.org> writes:
> On Fri, May 15, 2009 at 12:50:54PM -0400, Christoph Hellwig wrote:
>> On Fri, May 15, 2009 at 06:40:29PM +0200, Ferenc Wagner wrote:
>>> Thanks for the analysis. Unfortunately I don't nearly know enough to
>>> work on this issue, but would like to track it as it affects our
>>> backup system. So, shouldn't #2645 be reopened again?
>>
>> Yes, definitively as the current "fix" is incorrected. I'll try to cook
>> up a correct version once I get some time.
>
> Doing this correctly in the framework of the current codee is
> unfortunately not so easy, as calling ->setattr requires taking i_mutex
> which we can't in the pagefaul path.
>
> To fix this properly we need to actually update the timestamps during
> msync and co as done by the patches from Miklos:
> http://lkml.org/lkml/2007/2/28/166
> and Peter:
> http://lkml.org/lkml/2006/5/31/176
Hi Christoph,
http://bugzilla.kernel.org/show_bug.cgi?id=2645#c53 shows that Anton
doesn't quite agree with you on this. I really can't tell, would you
(or anybody from the accused XFS community) please comment? Or did
you perhaps fix it meanwhile? I can't easily test never kernels, but
I will if there's some chance.
--
Thanks,
Feri.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-07-22 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <874ovws94s.fsf@tac.ki.iif.hu>
[not found] ` <87ljp2v6vt.fsf@tac.ki.iif.hu>
2009-05-12 15:37 ` mmap vs mtime in 2.6.26 and up Ray Lee
2009-05-12 15:53 ` Christoph Hellwig
2009-05-15 16:40 ` Ferenc Wagner
2009-05-15 16:50 ` Christoph Hellwig
2009-05-18 11:43 ` Christoph Hellwig
2009-07-22 17:52 ` Ferenc Wagner [this message]
2009-09-25 12:47 ` Ferenc Wagner
2009-09-26 13:10 ` Christoph Hellwig
2009-10-15 0:08 ` Ferenc Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ab2w8v1y.fsf@tac.ki.iif.hu \
--to=wferi@niif.hu \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=ray-lk@madrabbit.org \
--cc=staubach@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox