From: kaixuxia <xiakaixu1987@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH v2 6/7] xfs: code cleanup in xfs_attr_leaf_entsize_{remote,local}
Date: Wed, 23 Sep 2020 11:21:15 +0800 [thread overview]
Message-ID: <87b07068-d71a-d25d-0ffd-39df88a57e1b@gmail.com> (raw)
In-Reply-To: <20200919062935.GD13501@infradead.org>
On 2020/9/19 14:29, Christoph Hellwig wrote:
> On Thu, Sep 17, 2020 at 07:38:47PM +0800, xiakaixu1987@gmail.com wrote:
>> static inline int xfs_attr_leaf_entsize_local(int nlen, int vlen)
>> {
>> - return ((uint)sizeof(xfs_attr_leaf_name_local_t) - 1 + (nlen) + (vlen) +
>> - XFS_ATTR_LEAF_NAME_ALIGN - 1) & ~(XFS_ATTR_LEAF_NAME_ALIGN - 1);
>> + return round_up(sizeof(struct xfs_attr_leaf_name_local) - 1 + nlen + vlen,
>
> Please avoid the overly long line here.
Okay, will fix it in the next version.
Thanks,
Kaixu
>
--
kaixuxia
next prev parent reply other threads:[~2020-09-23 3:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 11:38 [PATCH v2 0/7] xfs: random fixes and code cleanup xiakaixu1987
2020-09-17 11:38 ` [PATCH v2 1/7] xfs: remove the unused SYNCHRONIZE macro xiakaixu1987
2020-09-17 11:38 ` [PATCH v2 2/7] xfs: use the existing type definition for di_projid xiakaixu1987
2020-09-17 11:38 ` [PATCH v2 3/7] xfs: remove the unnecessary xfs_dqid_t type cast xiakaixu1987
2020-09-17 11:38 ` [PATCH v2 4/7] xfs: do the assert for all the log done items in xfs_trans_cancel xiakaixu1987
2020-09-17 18:18 ` Darrick J. Wong
2020-09-19 6:27 ` Christoph Hellwig
2020-09-23 3:26 ` kaixuxia
2020-09-17 11:38 ` [PATCH v2 5/7] xfs: remove the redundant crc feature check in xfs_attr3_rmt_verify xiakaixu1987
2020-09-17 18:18 ` Darrick J. Wong
2020-09-19 6:27 ` Christoph Hellwig
2020-09-19 6:28 ` Christoph Hellwig
2020-09-17 11:38 ` [PATCH v2 6/7] xfs: code cleanup in xfs_attr_leaf_entsize_{remote,local} xiakaixu1987
2020-09-17 18:19 ` Darrick J. Wong
2020-09-19 6:29 ` Christoph Hellwig
2020-09-23 3:21 ` kaixuxia [this message]
2020-09-17 11:38 ` [PATCH v2 7/7] xfs: fix some comments xiakaixu1987
2020-09-19 6:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87b07068-d71a-d25d-0ffd-39df88a57e1b@gmail.com \
--to=xiakaixu1987@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox