Re: [PATCH] PING... mkfs.xfs: fix static-lib build

Re: [PATCH] PING... mkfs.xfs: fix static-lib build

[Dmitry Monakhov]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]


I'm just want to double check that this list is still alive, and
not yet moved some where XXX-xfs@kernel.org  :)
Fellows, please take a look at the patch. This fix static build for
mkfs.xfs and break xfstests-bld build.


[-- Attachment #2.1: Type: text/plain, Size: 1766 bytes --]

Dmitry Monakhov <dmonakhov@openvz.org> writes:

> Order is important for static libraries, libblkid depends on libuuid.
> We have to pass libuuid after libblkid, otherwise it fails like this:
> #make mkfs.xfs
>     [LD]     mkfs.xfs
>     /bin/bash ../libtool --quiet --tag=CC --mode=link gcc -o mkfs.xfs -static -L/devel/xfstests-bld.git/bld/lib -static-libtool-libs  maxtrres.o proto.o xfs_mkfs.o   ../libxfs/libxfs.la ../libxcmd/libxcmd.la -luuid -lrt -lpthread -lblkid
>     /devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `set_uuid':
>     /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:132: undefined reference to `uuid_is_null'
>     /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:133: undefined reference to `uuid_unparse'
>     /devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `get_ext2_info':
>     /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:156: undefined reference to `uuid_is_null'
>     collect2: error: ld returned 1 exit status
>     ../include/buildrules:45: recipe for target 'mkfs.xfs' failed
>     make: *** [mkfs.xfs] Error 1
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
>  mkfs/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/Makefile b/mkfs/Makefile
> index 170e3c1..c13b903 100644
> --- a/mkfs/Makefile
> +++ b/mkfs/Makefile
> @@ -10,7 +10,7 @@ LTCOMMAND = mkfs.xfs
>  HFILES =
>  CFILES = maxtrres.c proto.c xfs_mkfs.c
>  
> -LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBUUID) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID)
> +LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID) $(LIBUUID)
>  LTDEPENDENCIES += $(LIBXFS) $(LIBXCMD)
>  LLDFLAGS = -static-libtool-libs
>  
> -- 
> 2.1.4

[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] PING... mkfs.xfs: fix static-lib build

[Dave Chinner]

On Fri, Aug 19, 2016 at 12:44:07PM +0300, Dmitry Monakhov wrote:
> 
> I'm just want to double check that this list is still alive, and
> not yet moved some where XXX-xfs@kernel.org  :)

linux-xfs@vger.kernel.org is active and we'll be moving there soon -
stay tuned. For the moment, I'll see any email you send there, at
least ;P

> > diff --git a/mkfs/Makefile b/mkfs/Makefile
> > index 170e3c1..c13b903 100644
> > --- a/mkfs/Makefile
> > +++ b/mkfs/Makefile
> > @@ -10,7 +10,7 @@ LTCOMMAND = mkfs.xfs
> >  HFILES =
> >  CFILES = maxtrres.c proto.c xfs_mkfs.c
> >  
> > -LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBUUID) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID)
> > +LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID) $(LIBUUID)
> >  LTDEPENDENCIES += $(LIBXFS) $(LIBXCMD)
> >  LLDFLAGS = -static-libtool-libs

I've already got a patch from Darrick to fix that in my queue.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs