From: Chandan Babu R <chandanbabu@kernel.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net, linux-xfs@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
mingo@kernel.org, peterz@infradead.org, anton@tuxera.com
Subject: Re: [RFC PATCH 2/3] fs: remove duplicate ifdefs
Date: Mon, 22 Jan 2024 18:20:13 +0530 [thread overview]
Message-ID: <87cyttedjj.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20240118080326.13137-3-sshegde@linux.ibm.com>
On Thu, Jan 18, 2024 at 01:33:25 PM +0530, Shrikanth Hegde wrote:
> when a ifdef is used in the below manner, second one could be considered as
> duplicate.
>
> ifdef DEFINE_A
> ...code block...
> ifdef DEFINE_A
> ...code block...
> endif
> ...code block...
> endif
>
> There are few places in fs code where above pattern was seen.
> No functional change is intended here. It only aims to improve code
> readability.
>
Can you please post the xfs changes as a separate patch along with Darrick's
RVB tag? This will make it easy for me to apply the resulting patch to the XFS
tree.
--
Chandan
next prev parent reply other threads:[~2024-01-22 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:03 [RFC PATCH 0/3] remove duplicate ifdefs Shrikanth Hegde
2024-01-18 8:03 ` [RFC PATCH 1/3] sched: " Shrikanth Hegde
2024-01-18 8:03 ` [RFC PATCH 2/3] fs: " Shrikanth Hegde
2024-01-19 1:35 ` Darrick J. Wong
2024-01-22 12:50 ` Chandan Babu R [this message]
2024-01-22 14:37 ` Shrikanth Hegde
2024-01-18 8:03 ` [RFC PATCH 3/3] arch/powerpc: " Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyttedjj.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandanbabu@kernel.org \
--cc=anton@tuxera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox