From: Chandan Babu R <chandanrlinux@gmail.com>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v19 13/14] xfs: Remove default ASSERT in xfs_attr_set_iter
Date: Thu, 27 May 2021 13:10:47 +0530 [thread overview]
Message-ID: <87fsy8oc8w.fsf@garuda> (raw)
In-Reply-To: <3d603e99-3f19-9138-5aa2-a659fd571057@oracle.com>
On 26 May 2021 at 23:43, Allison Henderson wrote:
> On 5/25/21 1:52 PM, Darrick J. Wong wrote:
>> On Tue, May 25, 2021 at 12:55:03PM -0700, Allison Henderson wrote:
>>> This ASSERT checks for the state value of RM_SHRINK in the set path.
>>> Which would be invalid, and should never happen. This change is being
>>> set aside from the rest of the set for further discussion
>>>
>>> Suggested-by: Darrick J. Wong <djwong@kernel.org>
>>> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
>>> ---
>>> fs/xfs/libxfs/xfs_attr.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
>>> index 32d451b..7294a2e 100644
>>> --- a/fs/xfs/libxfs/xfs_attr.c
>>> +++ b/fs/xfs/libxfs/xfs_attr.c
>>> @@ -612,7 +612,6 @@ xfs_attr_set_iter(
>>> error = xfs_attr_node_addname_clear_incomplete(dac);
>>> break;
>>> default:
>>> - ASSERT(dac->dela_state != XFS_DAS_RM_SHRINK);
>>
>> ASSERT(0); ?
>>
>> AFAICT the switch statement covers all the states mentioned in the state
>> diagram for attr setting, so in theory it should be impossible to land
>> in this state, correct?
> Yes, that's correct, so ASSERT(0); should work too. I am fine with
> this change if others are.
"ASSERT(0);" looks good to me as well.
--
chandan
next prev parent reply other threads:[~2021-05-27 7:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 19:54 [PATCH v19 00/14] Delay Ready Attributes Allison Henderson
2021-05-25 19:54 ` [PATCH v19 01/14] xfs: Reverse apply 72b97ea40d Allison Henderson
2021-05-25 19:54 ` [PATCH v19 02/14] xfs: Add xfs_attr_node_remove_name Allison Henderson
2021-05-25 19:54 ` [PATCH v19 03/14] xfs: Refactor xfs_attr_set_shortform Allison Henderson
2021-05-25 19:54 ` [PATCH v19 04/14] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete Allison Henderson
2021-05-25 19:54 ` [PATCH v19 05/14] xfs: Add helper xfs_attr_node_addname_find_attr Allison Henderson
2021-05-25 19:54 ` [PATCH v19 06/14] xfs: Hoist xfs_attr_node_addname Allison Henderson
2021-05-25 19:54 ` [PATCH v19 07/14] xfs: Hoist xfs_attr_leaf_addname Allison Henderson
2021-05-25 19:54 ` [PATCH v19 08/14] xfs: Hoist node transaction handling Allison Henderson
2021-05-25 19:54 ` [PATCH v19 09/14] xfs: Add delay ready attr remove routines Allison Henderson
2021-05-25 19:55 ` [PATCH v19 10/14] xfs: Add delay ready attr set routines Allison Henderson
2021-05-25 19:55 ` [PATCH v19 11/14] xfs: Remove xfs_attr_rmtval_set Allison Henderson
2021-05-25 20:34 ` Darrick J. Wong
2021-05-27 6:13 ` Chandan Babu R
2021-05-25 19:55 ` [PATCH v19 12/14] xfs: Clean up xfs_attr_node_addname_clear_incomplete Allison Henderson
2021-05-25 20:35 ` Darrick J. Wong
2021-05-27 7:03 ` Chandan Babu R
2021-05-25 19:55 ` [PATCH v19 13/14] xfs: Remove default ASSERT in xfs_attr_set_iter Allison Henderson
2021-05-25 20:52 ` Darrick J. Wong
2021-05-26 18:13 ` Allison Henderson
2021-05-27 7:40 ` Chandan Babu R [this message]
2021-05-25 19:55 ` [PATCH v19 14/14] xfs: Make attr name schemes consistent Allison Henderson
2021-05-25 20:36 ` Darrick J. Wong
2021-05-27 8:01 ` Chandan Babu R
2021-05-26 18:19 ` [PATCH v19 00/14] Delay Ready Attributes Darrick J. Wong
2021-05-27 16:54 ` Allison Henderson
2021-05-27 17:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsy8oc8w.fsf@garuda \
--to=chandanrlinux@gmail.com \
--cc=allison.henderson@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox