Re: [PATCHv9 1/6] iomap: Rename iomap_page to iomap_folio_state and others

Darrick J. Wong
2023-06-12T16:00:00Z

On Mon, Jun 12, 2023 at 04:08:51PM +0100, Matthew Wilcox wrote:
> On Mon, Jun 12, 2023 at 08:05:20AM -0700, Darrick J. Wong wrote:
> > static inline struct iomap_folio_state *
> > to_folio_state(struct folio *folio)
> > {
> > return folio->private;
> > }
>
> I'd reformat it to not-XFS-style:
>
> static inline struct iomap_folio_state *to_folio_state(struct folio *folio)
> {
> return folio->private;
> }
>
> But other than that, I approve. Unless you just want to do without it
> entirely and do
>
> struct iomap_folio_state *state = folio->private;
>
> instead of
>
> struct iomap_folio_state *state = to_folio_state(folio);
>
> I'm having a hard time caring between the two.

Either's fine with me too. I'm getting tired of reading this series
over and over again.

Ritesh: Please pick whichever variant you like, and that's it, no more
discussion.

--D