Re: [PATCHv9 1/6] iomap: Rename iomap_page to iomap_folio_state and others

Christoph Hellwig
2023-06-13T05:06:02Z

On Mon, Jun 12, 2023 at 04:08:51PM +0100, Matthew Wilcox wrote:
> But other than that, I approve. Unless you just want to do without it
> entirely and do
>
> struct iomap_folio_state *state = folio->private;
>
> instead of
>
> struct iomap_folio_state *state = to_folio_state(folio);
>
> I'm having a hard time caring between the two.

The direct dereference is fine to me as well and bypasses the naming
discussion entirely, which is always a plus.

I didn't notice the folio had switched to a void pointer for the private
data vs the always somewhat odd unsigned long in the page, making this
possibly and preferred by me.