public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Christoph Hellwig <hch@infradead.org>,
	Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	jake@lwn.net, djwong@kernel.org, dchinner@redhat.com,
	ritesh.list@gmail.com, rgoldwyn@suse.com, jack@suse.cz,
	linux-doc@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	p.raghav@samsung.com, da.gomez@samsung.com,
	rohan.puri@samsung.com
Subject: Re: [PATCH] Documentation: add initial iomap kdoc
Date: Thu, 18 May 2023 08:54:44 -0600	[thread overview]
Message-ID: <87h6s9666j.fsf@meer.lwn.net> (raw)
In-Reply-To: <ZGY7aumgDgU0jIK0@infradead.org>

Christoph Hellwig <hch@infradead.org> writes:

> On Thu, May 18, 2023 at 07:50:03AM -0700, Luis Chamberlain wrote:
>> On Thu, May 18, 2023 at 07:48:54AM -0700, Christoph Hellwig wrote:
>> > > +**iomap** allows filesystems to query storage media for data using *byte ranges*. Since block
>> > > +mapping are provided for a *byte ranges* for cache data in memory, in the page cache, naturally
>> > 
>> > Without fixing your line length I can't even read this mess..
>> 
>> I thought we are at 100?
>
> Ony for individual lines and when it improves readability (whatever
> that means).  But multiple to long lines, especially full of text
> are completely unreadable in a terminal.

Long text lines are definitely unfriendly to readers in general, so I
think we should absolutely avoid them in text - where they are
unnecessary to begin with.  Something to fix for the next iteration.

I'm glad to see this document, though; it's definitely a big gap in our
current coverage.

Thanks,

jon

  reply	other threads:[~2023-05-18 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 14:40 [PATCH] Documentation: add initial iomap kdoc Luis Chamberlain
2023-05-18 14:48 ` Christoph Hellwig
2023-05-18 14:50   ` Luis Chamberlain
2023-05-18 14:51     ` Christoph Hellwig
2023-05-18 14:54       ` Jonathan Corbet [this message]
2023-05-19  3:15       ` Theodore Ts'o
2023-05-19  9:28 ` Bagas Sanjaya
2023-05-19 15:13   ` Randy Dunlap
2023-05-19 23:25     ` Dave Chinner
2023-05-21 16:43       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6s9666j.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=da.gomez@samsung.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jake@lwn.net \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=rgoldwyn@suse.com \
    --cc=ritesh.list@gmail.com \
    --cc=rohan.puri@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox