From: Chandan Babu R <chandan.babu@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, amir73il@gmail.com, leah.rumancik@gmail.com
Subject: Re: [PATCH 5.4 CANDIDATE 00/18] xfs stable candidate patches for 5.4.y (from v5.5)
Date: Mon, 19 Sep 2022 10:02:00 +0530 [thread overview]
Message-ID: <87leqgnf2r.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <YyIi7NvA1xHylhoS@magnolia>
On Wed, Sep 14, 2022 at 11:52:28 AM -0700, Darrick J. Wong wrote:
> On Mon, Sep 12, 2022 at 06:57:24PM +0530, Chandan Babu R wrote:
>> Hi Darrick,
>>
>> This 5.4.y backport series contains fixes from v5.5 release.
>>
>> This patchset has been tested by executing fstests (via kdevops) using
>> the following XFS configurations,
>>
>> 1. No CRC (with 512 and 4k block size).
>> 2. Reflink/Rmapbt (1k and 4k block size).
>> 3. Reflink without Rmapbt.
>> 4. External log device.
>>
>> The following lists patches which required other dependency patches to
>> be included,
>>
>> 1. 050552cbe06a3a9c3f977dcf11ff998ae1d5c2d5
>> xfs: fix some memory leaks in log recovery
>> - 895e196fb6f84402dcd0c1d3c3feb8a58049564e
>> xfs: convert EIO to EFSCORRUPTED when log contents are invalid
>> - 895e196fb6f84402dcd0c1d3c3feb8a58049564e
>> xfs: constify the buffer pointer arguments to error functions
>> - a5155b870d687de1a5f07e774b49b1e8ef0f6f50
>> xfs: always log corruption errors
>> 2. 13eaec4b2adf2657b8167b67e27c97cc7314d923
>> xfs: don't commit sunit/swidth updates to disk if that would cause
>> repair failures
>> - 1cac233cfe71f21e069705a4930c18e48d897be6
>> xfs: refactor agfl length computation function
>> - 4f5b1b3a8fa07dc8ecedfaf539b3deed8931a73e
>> xfs: split the sunit parameter update into two parts
>
> For patches 1-2, 4, 7-14, 16-18,
> Acked-by: Darrick J. Wong <djwong@kernel.org>
>
> I don't know why patches 3, 5-6, or 15 are necessary -- I don't think
> they're fixing any user-visible issues; is that so that you can run QA
> with CONFIG_XFS_DEBUG=y and avoid false failures due to bad asserts?
>
Similar to testing upstream kernel, I thought I had configured the 5.4 LTS
kernel with CONFIG_XFS_DEBUG=y. But it turned out that I had not enabled the
option. I had to re-test both the unpatched and patched kernel once again to
make sure that there were no new regressions. Sorry about the delay in
responding.
I think I will drop patch 3. As stated by you, the remaining patches are
required to prevent false failures.
--
chandan
prev parent reply other threads:[~2022-09-19 4:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 13:27 [PATCH 5.4 CANDIDATE 00/18] xfs stable candidate patches for 5.4.y (from v5.5) Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 01/18] MAINTAINERS: add Chandan as xfs maintainer for 5.4.y Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 02/18] iomap: iomap that extends beyond EOF should be marked dirty Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 03/18] xfs: include QUOTA, FATAL ASSERT build options in XFS_BUILD_OPTIONS Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 04/18] xfs: replace -EIO with -EFSCORRUPTED for corrupt metadata Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 05/18] xfs: slightly tweak an assert in xfs_fs_map_blocks Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 06/18] xfs: add missing assert in xfs_fsmap_owner_from_rmap Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 07/18] xfs: range check ri_cnt when recovering log items Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 08/18] xfs: attach dquots and reserve quota blocks during unwritten conversion Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 09/18] xfs: Fix deadlock between AGI and AGF when target_ip exists in xfs_rename() Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 10/18] xfs: convert EIO to EFSCORRUPTED when log contents are invalid Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 11/18] xfs: constify the buffer pointer arguments to error functions Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 12/18] xfs: always log corruption errors Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 13/18] xfs: fix some memory leaks in log recovery Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 14/18] xfs: stabilize insert range start boundary to avoid COW writeback race Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 15/18] xfs: use bitops interface for buf log item AIL flag check Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 16/18] xfs: refactor agfl length computation function Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 17/18] xfs: split the sunit parameter update into two parts Chandan Babu R
2022-09-12 13:27 ` [PATCH 5.4 CANDIDATE 18/18] xfs: don't commit sunit/swidth updates to disk if that would cause repair failures Chandan Babu R
2022-09-14 18:52 ` [PATCH 5.4 CANDIDATE 00/18] xfs stable candidate patches for 5.4.y (from v5.5) Darrick J. Wong
2022-09-19 4:32 ` Chandan Babu R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leqgnf2r.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandan.babu@oracle.com \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=leah.rumancik@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox