public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] man: fix missing cachestat manpage
@ 2025-04-09 16:00 Darrick J. Wong
  2025-04-10  6:24 ` Christoph Hellwig
  2025-04-12  6:16 ` Ritesh Harjani
  0 siblings, 2 replies; 4+ messages in thread
From: Darrick J. Wong @ 2025-04-09 16:00 UTC (permalink / raw)
  To: Andrey Albershteyn; +Cc: linux-xfs, aalbersh, Ritesh Harjani (IBM)

From: Darrick J. Wong <djwong@kernel.org>

Fix missing cachestat documentation so that xfs/514 doesn't fail.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 man/man8/xfs_io.8 |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
index f36f1577a2b6c8..3c06e1b4d0fe2c 100644
--- a/man/man8/xfs_io.8
+++ b/man/man8/xfs_io.8
@@ -1101,6 +1101,9 @@ .SH FILE I/O COMMANDS
 Do not print timing information at all.
 .PD
 .RE
+.TP
+.BI "cachestat off len
+Print page cache statistics for the given file range.
 
 .SH MEMORY MAPPED I/O COMMANDS
 .TP

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] man: fix missing cachestat manpage
  2025-04-09 16:00 [PATCH] man: fix missing cachestat manpage Darrick J. Wong
@ 2025-04-10  6:24 ` Christoph Hellwig
  2025-04-12  6:16 ` Ritesh Harjani
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-04-10  6:24 UTC (permalink / raw)
  To: Darrick J. Wong
  Cc: Andrey Albershteyn, linux-xfs, aalbersh, Ritesh Harjani (IBM)

On Wed, Apr 09, 2025 at 09:00:59AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix missing cachestat documentation so that xfs/514 doesn't fail.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] man: fix missing cachestat manpage
  2025-04-09 16:00 [PATCH] man: fix missing cachestat manpage Darrick J. Wong
  2025-04-10  6:24 ` Christoph Hellwig
@ 2025-04-12  6:16 ` Ritesh Harjani
  2025-04-12  6:30   ` Ritesh Harjani
  1 sibling, 1 reply; 4+ messages in thread
From: Ritesh Harjani @ 2025-04-12  6:16 UTC (permalink / raw)
  To: Darrick J. Wong, Andrey Albershteyn; +Cc: linux-xfs, aalbersh

"Darrick J. Wong" <djwong@kernel.org> writes:

> From: Darrick J. Wong <djwong@kernel.org>
>
> Fix missing cachestat documentation so that xfs/514 doesn't fail.
>

Thanks for the fixing this. I didn't notice xfs/514 tests undocumented
xfs_db commands. 

The changes looks good to me. Please feel free to take:

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  man/man8/xfs_io.8 |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index f36f1577a2b6c8..3c06e1b4d0fe2c 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -1101,6 +1101,9 @@ .SH FILE I/O COMMANDS
>  Do not print timing information at all.
>  .PD
>  .RE
> +.TP
> +.BI "cachestat off len
> +Print page cache statistics for the given file range.
>  
>  .SH MEMORY MAPPED I/O COMMANDS
>  .TP

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] man: fix missing cachestat manpage
  2025-04-12  6:16 ` Ritesh Harjani
@ 2025-04-12  6:30   ` Ritesh Harjani
  0 siblings, 0 replies; 4+ messages in thread
From: Ritesh Harjani @ 2025-04-12  6:30 UTC (permalink / raw)
  To: Darrick J. Wong, Andrey Albershteyn; +Cc: linux-xfs, aalbersh

Ritesh Harjani (IBM) <ritesh.list@gmail.com> writes:

> "Darrick J. Wong" <djwong@kernel.org> writes:
>
>> From: Darrick J. Wong <djwong@kernel.org>
>>
>> Fix missing cachestat documentation so that xfs/514 doesn't fail.
>>
>
> Thanks for the fixing this. I didn't notice xfs/514 tests undocumented
> xfs_db commands. 

For xfs_io, xfs/293 tests for undocumented commands.

-ritesh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-04-12  6:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-09 16:00 [PATCH] man: fix missing cachestat manpage Darrick J. Wong
2025-04-10  6:24 ` Christoph Hellwig
2025-04-12  6:16 ` Ritesh Harjani
2025-04-12  6:30   ` Ritesh Harjani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox