Re: [PATCH V4 17/20] xfsprogs: xfs_info: Report NREXT64 feature status

Darrick J. Wong
2022-01-05T01:13:59Z

On Tue, Dec 14, 2021 at 02:18:08PM +0530, Chandan Babu R wrote:
> This commit adds support to libfrog to obtain information about the
> availability of NREXT64 feature in the underlying filesystem.
>
> Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>

LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
> libfrog/fsgeom.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libfrog/fsgeom.c b/libfrog/fsgeom.c
> index 4f1a1842..3e7f0797 100644
> --- a/libfrog/fsgeom.c
> +++ b/libfrog/fsgeom.c
> @@ -30,6 +30,7 @@ xfs_report_geom(
> int reflink_enabled;
> int bigtime_enabled;
> int inobtcount;
> + int nrext64;
>
> isint = geo->logstart > 0;
> lazycount = geo->flags & XFS_FSOP_GEOM_FLAGS_LAZYSB ? 1 : 0;
> @@ -47,12 +48,13 @@ xfs_report_geom(
> reflink_enabled = geo->flags & XFS_FSOP_GEOM_FLAGS_REFLINK ? 1 : 0;
> bigtime_enabled = geo->flags & XFS_FSOP_GEOM_FLAGS_BIGTIME ? 1 : 0;
> inobtcount = geo->flags & XFS_FSOP_GEOM_FLAGS_INOBTCNT ? 1 : 0;
> + nrext64 = geo->flags & XFS_FSOP_GEOM_FLAGS_NREXT64 ? 1 : 0;
>
> printf(_(
> "meta-data=%-22s isize=%-6d agcount=%u, agsize=%u blks\n"
> " =%-22s sectsz=%-5u attr=%u, projid32bit=%u\n"
> " =%-22s crc=%-8u finobt=%u, sparse=%u, rmapbt=%u\n"
> -" =%-22s reflink=%-4u bigtime=%u inobtcount=%u\n"
> +" =%-22s reflink=%-4u bigtime=%u inobtcount=%u nrext64=%u\n"
> "data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n"
> " =%-22s sunit=%-6u swidth=%u blks\n"
> "naming =version %-14u bsize=%-6u ascii-ci=%d, ftype=%d\n"
> @@ -62,7 +64,7 @@ xfs_report_geom(
> mntpoint, geo->inodesize, geo->agcount, geo->agblocks,
> "", geo->sectsize, attrversion, projid32bit,
> "", crcs_enabled, finobt_enabled, spinodes, rmapbt_enabled,
> - "", reflink_enabled, bigtime_enabled, inobtcount,
> + "", reflink_enabled, bigtime_enabled, inobtcount, nrext64,
> "", geo->blocksize, (unsigned long long)geo->datablocks,
> geo->imaxpct,
> "", geo->sunit, geo->swidth,
> --
> 2.30.2
>