From: Chandan Babu R <chandanrlinux@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me, amir73il@gmail.com,
ebiggers@kernel.org
Subject: Re: [PATCH 10/13] check: use generated group files
Date: Fri, 11 Jun 2021 13:19:56 +0530 [thread overview]
Message-ID: <87sg1o3knv.fsf@garuda> (raw)
In-Reply-To: <162317281679.653489.1178774292862746443.stgit@locust>
On 08 Jun 2021 at 22:50, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Convert the ./check script to use the automatically generated group list
> membership files, as the transition is now complete.
>
Looks good.
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> check | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
> diff --git a/check b/check
> index ba192042..3dab7630 100755
> --- a/check
> +++ b/check
> @@ -124,9 +124,9 @@ get_sub_group_list()
> local d=$1
> local grp=$2
>
> - test -s "$SRC_DIR/$d/group" || return 1
> + test -s "$SRC_DIR/$d/group.list" || return 1
>
> - local grpl=$(sed -n < $SRC_DIR/$d/group \
> + local grpl=$(sed -n < $SRC_DIR/$d/group.list \
> -e 's/#.*//' \
> -e 's/$/ /' \
> -e "s;^\($VALID_TEST_NAME\).* $grp .*;$SRC_DIR/$d/\1;p")
> @@ -384,7 +384,7 @@ if $have_test_arg; then
> test_dir=`dirname $t`
> test_dir=${test_dir#$SRC_DIR/*}
> test_name=`basename $t`
> - group_file=$SRC_DIR/$test_dir/group
> + group_file=$SRC_DIR/$test_dir/group.list
>
> if egrep -q "^$test_name" $group_file; then
> # in group file ... OK
--
chandan
next prev parent reply other threads:[~2021-06-11 7:50 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 17:19 [PATCHSET v1 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-08 17:19 ` [PATCH 01/13] fstests: fix group check in new script Darrick J. Wong
2021-06-10 8:43 ` Chandan Babu R
2021-06-11 21:54 ` Allison Henderson
2021-06-08 17:19 ` [PATCH 02/13] misc: move exit status into trap handler Darrick J. Wong
2021-06-10 8:43 ` Chandan Babu R
2021-06-11 21:55 ` Allison Henderson
2021-06-08 17:19 ` [PATCH 03/13] fstests: refactor test boilerplate code Darrick J. Wong
2021-06-10 8:44 ` Chandan Babu R
2021-06-11 21:55 ` Allison Henderson
2021-06-12 0:08 ` Eric Biggers
2021-06-12 0:34 ` Darrick J. Wong
2021-06-08 17:19 ` [PATCH 04/13] fstests: add tool migrate group membership data to test files Darrick J. Wong
2021-06-10 8:44 ` Chandan Babu R
2021-06-11 21:55 ` Allison Henderson
2021-06-08 17:19 ` [PATCH 05/13] fstests: move test group info " Darrick J. Wong
2021-06-11 21:55 ` Allison Henderson
2021-06-11 23:29 ` Eric Biggers
2021-06-12 0:17 ` Eric Biggers
2021-06-12 0:34 ` Darrick J. Wong
2021-06-08 17:19 ` [PATCH 06/13] fstests: clean up open-coded golden output Darrick J. Wong
2021-06-10 8:57 ` Chandan Babu R
2021-06-11 21:55 ` Allison Henderson
2021-06-08 17:20 ` [PATCH 07/13] fstests: automatically generate group files Darrick J. Wong
2021-06-11 5:39 ` Chandan Babu R
2021-06-11 23:37 ` [PATCH v1.1 " Darrick J. Wong
2021-06-14 5:38 ` Allison Henderson
2021-06-08 17:20 ` [PATCH 08/13] fstests: convert nextid to use automatic group generation Darrick J. Wong
2021-06-11 6:31 ` Chandan Babu R
2021-06-11 23:46 ` Eric Biggers
2021-06-12 0:40 ` Darrick J. Wong
2021-06-14 5:38 ` Allison Henderson
2021-06-08 17:20 ` [PATCH 09/13] fstests: adapt the new test script to our new group tagging scheme Darrick J. Wong
2021-06-11 6:55 ` Chandan Babu R
2021-06-14 5:38 ` Allison Henderson
2021-06-08 17:20 ` [PATCH 10/13] check: use generated group files Darrick J. Wong
2021-06-11 7:49 ` Chandan Babu R [this message]
2021-06-14 19:39 ` Allison Henderson
2021-06-08 17:20 ` [PATCH 11/13] fstests: remove " Darrick J. Wong
2021-06-11 7:53 ` Chandan Babu R
2021-06-11 23:24 ` Eric Biggers
2021-06-11 23:29 ` Darrick J. Wong
2021-06-11 23:51 ` Eric Biggers
2021-06-14 19:39 ` Allison Henderson
2021-06-08 17:20 ` [PATCH 12/13] fstests: remove test group management code Darrick J. Wong
2021-06-11 8:19 ` Chandan Babu R
2021-06-14 19:39 ` Allison Henderson
2021-06-08 17:20 ` [PATCH 13/13] misc: update documentation to reflect auto-generated group files Darrick J. Wong
2021-06-11 8:23 ` Chandan Babu R
2021-06-14 19:39 ` Allison Henderson
2021-06-14 20:49 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2021-06-14 20:58 [PATCHSET v2 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-14 20:59 ` [PATCH 10/13] check: use generated group files Darrick J. Wong
2021-06-16 20:55 ` Eric Biggers
2021-06-21 23:10 [PATCHSET v3 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-21 23:11 ` [PATCH 10/13] check: use generated group files Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg1o3knv.fsf@garuda \
--to=chandanrlinux@gmail.com \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox