Re: [PATCH 7/9] xfs_mdrestore: emit newlines for fatal errors

Chandan Babu R
2023-11-24T09:16:13Z

On Wed, Nov 22, 2023 at 03:07:28 PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Spit out a newline after a fatal error message.
>

Looks good to me.

Reviewed-by: Chandan Babu R <chandanbabu@kernel.org>

> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> mdrestore/xfs_mdrestore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/mdrestore/xfs_mdrestore.c b/mdrestore/xfs_mdrestore.c
> index 5dfc423493e..3190e07e478 100644
> --- a/mdrestore/xfs_mdrestore.c
> +++ b/mdrestore/xfs_mdrestore.c
> @@ -275,10 +275,10 @@ read_header_v2(
> fatal("error reading from metadump file\n");
>
> if (h->v2.xmh_incompat_flags != 0)
> - fatal("Metadump header has unknown incompat flags set");
> + fatal("Metadump header has unknown incompat flags set\n");
>
> if (h->v2.xmh_reserved != 0)
> - fatal("Metadump header's reserved field has a non-zero value");
> + fatal("Metadump header's reserved field has a non-zero value\n");
>
> want_external_log = !!(be32_to_cpu(h->v2.xmh_incompat_flags) &
> XFS_MD2_COMPAT_EXTERNALLOG);

--
Chandan