From: Chandan Babu R <chandan.babu@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, cem@kernel.org
Subject: Re: [PATCH V3 10/23] metadump: Define metadump v2 ondisk format structures and macros
Date: Wed, 02 Aug 2023 18:38:20 +0530 [thread overview]
Message-ID: <87ttthr37f.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20230801234753.GR11352@frogsfrogsfrogs>
On Tue, Aug 01, 2023 at 04:47:53 PM -0700, Darrick J. Wong wrote:
> On Mon, Jul 24, 2023 at 10:05:14AM +0530, Chandan Babu R wrote:
>> The corresponding metadump file's disk layout is as shown below,
>>
>> |------------------------------|
>> | struct xfs_metadump_header |
>> |------------------------------|
>> | struct xfs_meta_extent 0 |
>> | Extent 0's data |
>> | struct xfs_meta_extent 1 |
>> | Extent 1's data |
>> | ... |
>> | struct xfs_meta_extent (n-1) |
>> | Extent (n-1)'s data |
>> |------------------------------|
>>
>> The "struct xfs_metadump_header" is followed by alternating series of "struct
>> xfs_meta_extent" and the extent itself.
>>
>> Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
>
> Looks good,
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> Could you please post a patch describing the metadump2 file format for
> https://git.kernel.org/pub/scm/fs/xfs/xfs-documentation.git/ ?
Sure, I will do that.
>
> (Sorry I posted an earlier reply to the truncated submission.)
>
> --D
>
--
chandan
next prev parent reply other threads:[~2023-08-02 13:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 4:35 [PATCH V3 00/23] Metadump v2 Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 01/23] metadump: Use boolean values true/false instead of 1/0 Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 02/23] mdrestore: Fix logic used to check if target device is large enough Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 03/23] metadump: Declare boolean variables with bool type Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 04/23] metadump: Define and use struct metadump Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 05/23] metadump: Add initialization and release functions Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 06/23] metadump: Postpone invocation of init_metadump() Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 07/23] metadump: Introduce struct metadump_ops Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 08/23] metadump: Introduce metadump v1 operations Chandan Babu R
2023-08-01 23:44 ` Darrick J. Wong
2023-07-24 4:35 ` [PATCH V3 09/23] metadump: Rename XFS_MD_MAGIC to XFS_MD_MAGIC_V1 Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 10/23] metadump: Define metadump v2 ondisk format structures and macros Chandan Babu R
2023-08-01 23:47 ` Darrick J. Wong
2023-08-02 13:08 ` Chandan Babu R [this message]
2023-07-24 4:35 ` [PATCH V3 11/23] metadump: Define metadump ops for v2 format Chandan Babu R
2023-08-01 23:49 ` Darrick J. Wong
2023-08-02 13:08 ` Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 12/23] xfs_db: Add support to read from external log device Chandan Babu R
2023-08-01 23:49 ` Darrick J. Wong
2023-07-24 4:35 ` [PATCH V3 13/23] metadump: Add support for passing version option Chandan Babu R
2023-08-01 23:51 ` Darrick J. Wong
2023-08-02 13:18 ` Chandan Babu R
2023-08-02 17:14 ` Darrick J. Wong
2023-07-24 4:35 ` [PATCH V3 14/23] mdrestore: Declare boolean variables with bool type Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 15/23] mdrestore: Define and use struct mdrestore Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 16/23] mdrestore: Detect metadump v1 magic before reading the header Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 17/23] mdrestore: Add open_device(), read_header() and show_info() functions Chandan Babu R
2023-08-01 23:54 ` Darrick J. Wong
2023-07-24 4:35 ` [PATCH V3 18/23] mdrestore: Introduce struct mdrestore_ops Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 19/23] mdrestore: Replace metadump header pointer argument with a union pointer Chandan Babu R
2023-08-02 0:01 ` Darrick J. Wong
2023-08-02 13:17 ` Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 20/23] mdrestore: Introduce mdrestore v1 operations Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 21/23] mdrestore: Extract target device size verification into a function Chandan Babu R
2023-07-24 4:35 ` [PATCH V3 22/23] mdrestore: Define mdrestore ops for v2 format Chandan Babu R
2023-08-02 17:16 ` Darrick J. Wong
2023-07-24 4:35 ` [PATCH V3 23/23] mdrestore: Add support for passing log device as an argument Chandan Babu R
2023-10-31 16:46 ` [PATCH V3 00/23] Metadump v2 Darrick J. Wong
2023-11-01 14:58 ` Carlos Maiolino
2023-11-01 18:02 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2023-07-21 9:45 Chandan Babu R
2023-07-21 9:45 ` [PATCH V3 10/23] metadump: Define metadump v2 ondisk format structures and macros Chandan Babu R
2023-08-01 23:46 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttthr37f.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandan.babu@oracle.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox